Use localeCompare instead of simple unicode point comparison #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: https://phabricator.wikimedia.org/T407180 Change-Id: I5bcda3b5f0dd732ac0612671987fa981c03a9bc8
hueitan
approved these changes
Oct 15, 2025
Member
hueitan
left a comment
hueitan
left a comment
There was a problem hiding this comment.
localCompare is a great improvement 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: https://phabricator.wikimedia.org/T407180
Change-Id: I5bcda3b5f0dd732ac0612671987fa981c03a9bc8