Skip to content

Conversation

@Abijeet
Copy link
Member

@Abijeet Abijeet commented Oct 14, 2025

@Abijeet Abijeet requested review from Nikerabbit and hueitan October 14, 2025 08:51
@Abijeet Abijeet self-assigned this Oct 14, 2025
@Abijeet Abijeet added the chore label Oct 14, 2025
@Abijeet Abijeet force-pushed the fix-docs branch 2 times, most recently from 38ff992 to f460bf3 Compare October 14, 2025 09:05
@Abijeet
Copy link
Member Author

Abijeet commented Oct 14, 2025

Primarily use const, and arrow functions wherever possible.

Bug: https://phabricator.wikimedia.org/T407180
Change-Id: Ib64d5b47ad0ac155a46b7f26cf8cc373215577e6
Copy link
Member

@hueitan hueitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Abijeet Abijeet force-pushed the esm-module branch 2 times, most recently from 42e0290 to 9e6c415 Compare October 15, 2025 06:54
ToluAyo and others added 11 commits October 15, 2025 12:53
Downstream task: https://phabricator.wikimedia.org/T409846

Co-authored-by: ToluAyo <tayodele-ctr@wikimedia.org>
Downstream task: Downstream task: https://phabricator.wikimedia.org/T409846

Co-authored-by: ToluAyo <tayodele-ctr@wikimedia.org>
The above mentioned library is required for generationg
`language-data.json` by parsing YAML langdb.yaml file. The script only
runs when languages are added/removed/modified, so it does not impact
normal operation. This change moved the library to a dev dependency.

Bug: T410029

Co-authored-by: Wangombe <ewangombe-ctr@wikimedia.org>
* php.yml: Test on PHP 8.3 and 8.4

* php.yml: Test on PHP 8.5

---------

Co-authored-by: James D. Forrester <jforrester@wikimedia.org>
….json (#464)

Follow-up to PR #457

Bug: T410029

Co-authored-by: Wangombe <ewangombe-ctr@wikimedia.org>
Change-Id: Ie7aa32b3a7c926fe73cfeb2c205e67019805f9a4
Co-authored-by: James D. Forrester <jforrester@wikimedia.org>
Dropped support for Node.js 16, 18.
Updated ESLint to v9 since assert is not supported in v8. See:
eslint/eslint#15305

Dropping support for Node v16, v18 should be fine as they are both EOL.

Consequently had to drop support for Wikimedia/eslint rules as it
doesn't yet support ESLint v9.

Bug: https://phabricator.wikimedia.org/T407180
Change-Id: I44dee29b49804da5a13d986352148931baf7cb34
@Abijeet
Copy link
Member Author

Abijeet commented Dec 3, 2025

Closed in favor of #472

@Abijeet Abijeet closed this Dec 3, 2025
@Abijeet Abijeet deleted the fix-docs branch December 3, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

6 participants