-
Notifications
You must be signed in to change notification settings - Fork 29
docs: Add readthedocs configuration file, update dependencies #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38ff992 to
f460bf3
Compare
Member
Author
48e26ca to
134ed14
Compare
Primarily use const, and arrow functions wherever possible. Bug: https://phabricator.wikimedia.org/T407180 Change-Id: Ib64d5b47ad0ac155a46b7f26cf8cc373215577e6
hueitan
approved these changes
Oct 14, 2025
Member
hueitan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
42e0290 to
9e6c415
Compare
Downstream task: https://phabricator.wikimedia.org/T409846 Co-authored-by: ToluAyo <tayodele-ctr@wikimedia.org>
Downstream task: Downstream task: https://phabricator.wikimedia.org/T409846 Co-authored-by: ToluAyo <tayodele-ctr@wikimedia.org>
The above mentioned library is required for generationg `language-data.json` by parsing YAML langdb.yaml file. The script only runs when languages are added/removed/modified, so it does not impact normal operation. This change moved the library to a dev dependency. Bug: T410029 Co-authored-by: Wangombe <ewangombe-ctr@wikimedia.org>
* php.yml: Test on PHP 8.3 and 8.4 * php.yml: Test on PHP 8.5 --------- Co-authored-by: James D. Forrester <jforrester@wikimedia.org>
Change-Id: Ie7aa32b3a7c926fe73cfeb2c205e67019805f9a4
Bug: https://phabricator.wikimedia.org/T407180 Change-Id: I5bcda3b5f0dd732ac0612671987fa981c03a9bc8
Dropped support for Node.js 16, 18. Updated ESLint to v9 since assert is not supported in v8. See: eslint/eslint#15305 Dropping support for Node v16, v18 should be fine as they are both EOL. Consequently had to drop support for Wikimedia/eslint rules as it doesn't yet support ESLint v9. Bug: https://phabricator.wikimedia.org/T407180 Change-Id: I44dee29b49804da5a13d986352148931baf7cb34
See: https://docs.readthedocs.com/platform/stable/config-file/index.html Bug: https://phabricator.wikimedia.org/T407180 Change-Id: I77414b912da7a5b0fdc5445952e5d08911de593c
Member
Author
|
Closed in favor of #472 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://docs.readthedocs.com/platform/stable/config-file/index.html
Bug: https://phabricator.wikimedia.org/T407180
Change-Id: I77414b912da7a5b0fdc5445952e5d08911de593c