Use localeCompare instead of simple unicode point comparison (#454)

Abijeet · web-flow · commit 8e03ecfd20e2 · 2025-12-04T00:12:04.000+01:00
Bug: https://phabricator.wikimedia.org/T407180 Change-Id: I5bcda3b5f0dd732ac0612671987fa981c03a9bc8
diff --git a/src/index.js b/src/index.js
@@ -243,7 +243,7 @@ function sortByScriptGroup( languages ) {
 function sortByAutonym( a, b ) {
 	const autonymA = getAutonym( a ) || a,
 		autonymB = getAutonym( b ) || b;
-	return ( autonymA.toLowerCase() < autonymB.toLowerCase() ) ? -1 : 1;
+	return autonymA.localeCompare( autonymB );
 }
 
 /**
diff --git a/tests/js/index.js b/tests/js/index.js
@@ -153,7 +153,7 @@ describe( 'languagedata', () => {
 		const languagesAM = [ 'atj', 'chr', 'chy', 'cr', 'en', 'es', 'fr', 'gn', 'haw', 'ike-cans', 'ik', 'kl', 'nl', 'pt', 'qu', 'srn', 'yi' ];
 		assert.deepEqual(
 			languageData.sortByScriptGroup( languagesAM.sort( languageData.sortByAutonym ) ),
-			[ 'atj', 'gn', 'en', 'es', 'fr', 'haw', 'ik', 'kl', 'nl', 'pt', 'qu', 'srn', 'chy', 'yi', 'ike-cans', 'cr', 'chr' ],
+			[ 'atj', 'gn', 'en', 'es', 'fr', 'haw', 'ik', 'kl', 'nl', 'pt', 'qu', 'srn', 'chy', 'yi', 'chr', 'ike-cans', 'cr' ],
 			'languages in region AM are ordered correctly by script group'
 		);
 

Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ function sortByScriptGroup( languages ) {`
`243`	`243`	`function sortByAutonym( a, b ) {`
`244`	`244`	`const autonymA = getAutonym( a ) \|\| a,`
`245`	`245`	`autonymB = getAutonym( b ) \|\| b;`
`246`		`- return ( autonymA.toLowerCase() < autonymB.toLowerCase() ) ? -1 : 1;`
	`246`	`+ return autonymA.localeCompare( autonymB );`
`247`	`247`	`}`
`248`	`248`
`249`	`249`	`/**`