Skip to content

Update deleted_prods report to use new comment table #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MusikAnimal merged 1 commit into from
Nov 16, 2018
Merged

Update deleted_prods report to use new comment table #24

MusikAnimal merged 1 commit into from
Nov 16, 2018

Conversation

@MusikAnimal
Copy link
Member

@MusikAnimal MusikAnimal commented Nov 16, 2018 •
edited
Loading

aezell
aezell approved these changes Nov 16, 2018
View reviewed changes
Copy link

@aezell aezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test but the change looks good.

@MusikAnimal
Copy link
Member Author

MusikAnimal commented Nov 16, 2018

I tested in the MariaDB console. Just run the query that's in the source. I'm assuming this is OK to merge. I shall deploy now!

@MusikAnimal MusikAnimal merged commit 35d67fc into master Nov 16, 2018
@MusikAnimal MusikAnimal deleted the log-comments branch November 16, 2018 23:52
@MusikAnimal
Copy link
Member Author

MusikAnimal commented Nov 16, 2018

Actually, I can't deploy. I'm not a member of database-reports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Niharika29 Niharika29 Awaiting requested review from Niharika29

1 more reviewer

@aezell aezell aezell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MusikAnimal @aezell