bugfix nerf categories + new most_watched + fr dict #12
Conversation
framawiki
changed the title
need better fix
need better fix
SQL query from MZMcBride https://en.wikipedia.org/w/index.php?title=User_talk:BernsteinBot&diff=762334008&oldid=762110908 (Public domain; bjweeks, MZMcBride; 2009, 2017)
# Conflicts: # displayTable.py
fix²²
framawiki
changed the title
|
Is this ready for a merge? :) |
displayTable.py
Outdated
| @param wiki - Language code for the wiki (eg: 'en', 'es', 'it') | ||
| @param content - Python 2D array (nested list) containing table entries | ||
| @param desc - Key to the description message of the report | ||
| @param numbers - If table have to contain numbers of rows |
There was a problem hiding this comment.
Is this param used anywhere?
There was a problem hiding this comment.
Not yet used.
My main idea was to create an option to allow to add lines number in tables. I've reverted it and for the time being preferred hard code it for each report that need it.
There was a problem hiding this comment.
I still see this in the diff. Better remove it completely and we can add something to automatically add line numbers. That would be simpler.
framawiki
changed the title
|
This is ready to merge. |
| def pages_with_most_revisions( self ): | ||
| self.rep.pages_with_most_revisions() | ||
|
|
||
| def blank_pages( self ): |
There was a problem hiding this comment.
Not sure why this has been dropped. Is the report no longer needed? Sorry I haven't looked at this stuff in a while.
There was a problem hiding this comment.
I just see that this function do nothing - looks like the rest of this quarry was removed
There was a problem hiding this comment.
But at same time you have written "fixed in BernsteinBot" in remove commit message, is it possible to keep the function, if it's functional, in this repo ?
reports.py
Outdated
| i += 1 | ||
|
|
||
| # Format the data as wikitext | ||
| text = display_report(self.wiki, content, 'most_watched-desc') |
There was a problem hiding this comment.
( self.wiki, content, 'most-watched-desc' )
Similarly for line below.
Just trying to keep a consistent style here. :)
reports.py
Outdated
| reports_base_url = dict_obj[ str( 'reports_base_url' ) ] | ||
| report_title = dict_obj[ str( title ) ] | ||
| print str( reports_base_url + report_title ) | ||
| print(str( reports_base_url + report_title )) |
There was a problem hiding this comment.
What's the difference?
There was a problem hiding this comment.
Habits :) removed.
i18n/i18n.py
Outdated
| "most_edited_page_last_month-editcount": "Revisions", | ||
|
|
||
| "most_watched-page-title": "Most-watched pages", | ||
| "most_watched-desc": "Most-watched non-deleted pages (limited to the first 1000 entries)", |
There was a problem hiding this comment.
Non-deleted seems obvious, no?
There was a problem hiding this comment.
Yes, I've removed this in the English dict, but keep for French : there are few old pages that was deleted but followed by lot of accounts.
framawiki
changed the title
|
Thanks for your review and advice :) |
|
Hey, @framawiki. Sorry to get back to this so late. Are you still interested in getting this merged? |
3 participants
No description provided.