Merge pull request #34 from wikimedia/2022-update

MusikAnimal · web-flow · commit 9bac35d65637 · 2022-04-18T19:58:23.000-04:00
Fix Python 3.8 deprecations, update README
diff --git a/README.md b/README.md
@@ -16,7 +16,6 @@ This project allows the [Community Tech bot](https://en.wikipedia.org/wiki/User:
 * Page count by namespace
 * Most edited articles last month
 * PRODed articles with deletion logs
-* Editors eligible for autopatrol privileges
 * Active editors with the longest-established accounts
 
 ## Installation
@@ -29,10 +28,17 @@ Virtualenv is recommended:
 After installation, either activate virtualenv like above or use `venv/bin/python` to run scripts.
 
 ## Generating a report
-* Log into the Toolforge bastion using your Wikimedia developer account ```ssh username@login.tools.wmflabs.org```
-* Become your tool account ```become database-reports```
-* Run ```python3 main.py test articles_by_size```. It takes two arguments; in this example test refers to `test.wikipedia.org` and `articles_by_size` is the type of statistics you're requesting. This command outputs the name of the page on which the report got dumped
-* To alter the default settings for periodic updates, make changes to the crontab file ```crontab -e```
+
+Run ```python3 main.py test orphaned_talk```. It takes two arguments; in this example test refers to
+`test.wikipedia.org` and `orphaned_talk` is the type of statistics you're requesting. This command outputs
+the name of the page on which the report got dumped.
+
+You can pass the ```--dry-run``` flag to print output to stdout rather than editing the wiki.
+
+On Toolforge, the reports are defined in the ```jobs.yaml``` file.
+See the [Toolforge jobs framework documentation](https://wikitech.wikimedia.org/wiki/Help:Toolforge/Jobs_framework) for more information.
+
+If you need to run a one-off job on Toolforge, find the corresponding command in ```jobs.yaml``` and [schedule it](https://wikitech.wikimedia.org/wiki/Help:Toolforge/Jobs_framework#Creating_one-off_jobs) using ```toolforge-jobs```.
 
 ## Adding support for a report
 * To add support for a specific statistics that you would like to see in a report, declare a function in `main.py` and define it in `reports.py`
@@ -42,4 +48,4 @@ After installation, either activate virtualenv like above or use `venv/bin/pytho
 Bug reports, fixes, and new features are welcomed. If you'd like to contribute code please:
 * Fork the project
 * Start a branch named for your new feature or bug
-* Create a pull request
+* Create a pull request
diff --git a/reports.py b/reports.py
@@ -456,7 +456,7 @@ def linkify( self, title, namespace = None ):
 		title_clean = title.replace( '_', ' ' )
 		if namespace is None:
 			return '[[' + title_clean + ']]'
-		elif namespace is 6:
+		elif namespace == 6:
 			return '[[:{{subst:ns:%s}}:%s]]' % ( namespace, title_clean )
 		else:
 			return '[[{{subst:ns:%s}}:%s]]' % ( namespace, title_clean )
