Implements missing functions firstKey / nextKey / exists #1
Conversation
noony
changed the title
|
@noony Wow. Sorry that we didn't get you any feedback on this patch sooner. :/ |
|
Thanks ! |
src/Reader/PHP.php
Outdated
|
Some trivial comments inline. Overall this looks good though. |
… the first key to avoid code duplication
|
Thanks @bd808, I've made modifications related to your code review, hope that's will be good now :) |
Implements missing functions firstKey / nextKey / exists
|
@noony Thanks for the patch |
|
@legoktm Did I just mess up the world by merging this here? Is CDB really managed in gerrit? |
|
I assume that if you pushed it into the gerrit repository, everything would be fine? This is definitely a Gerrit mirror repo: https://gerrit.wikimedia.org/r/#/q/project:cdb,n,z |
|
I did a push into gerrit to make the state there match the github repo after this merge. Things should be fine now and next time I'm pretty sure I'll remember to run the patches through gerrit instead. Sorry for the temporary mess. |
When tests are skipped, there is a deprecation notice Deprecated: unlink(): Passing null to parameter #1 ($filename) of type string is deprecated in tests\CdbTest.php on line 34 Change-Id: I2c34859371d4e6f1d17fcd54b1f378af39bae0c0
3 participants
No description provided.