tests: Avoid null passed to unlink

umherirrender · umherirrender · commit 6ef35a243e00 · 2024-10-04T00:57:48.000+02:00
When tests are skipped, there is a deprecation notice Deprecated: unlink(): Passing null to parameter #1 ($filename) of type string is deprecated in tests\CdbTest.php on line 34 Change-Id: I2c34859371d4e6f1d17fcd54b1f378af39bae0c0
diff --git a/tests/CdbTest.php b/tests/CdbTest.php
@@ -31,8 +31,12 @@ protected function setUp(): void {
 	}
 
 	protected function tearDown(): void {
-		unlink( $this->phpCdbFile );
-		unlink( $this->dbaCdbFile );
+		if ( $this->phpCdbFile !== null ) {
+			unlink( $this->phpCdbFile );
+		}
+		if ( $this->dbaCdbFile !== null ) {
+			unlink( $this->dbaCdbFile );
+		}
 		parent::tearDown();
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -31,8 +31,12 @@ protected function setUp(): void {`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`protected function tearDown(): void {`
`34`		`- unlink( $this->phpCdbFile );`
`35`		`- unlink( $this->dbaCdbFile );`
	`34`	`+ if ( $this->phpCdbFile !== null ) {`
	`35`	`+ unlink( $this->phpCdbFile );`
	`36`	`+ }`
	`37`	`+ if ( $this->dbaCdbFile !== null ) {`
	`38`	`+ unlink( $this->dbaCdbFile );`
	`39`	`+ }`
`36`	`40`	`parent::tearDown();`
`37`	`41`	`}`
`38`	`42`