Move property initialization up and add missing docs

thiemowmde · Krinkle · commit 54cad84cc56c · 2022-11-17T19:44:33.000Z
Some simple clean-ups that don't change how the code behaves.

Change-Id: I849c9c822ce39f27cc91b32e2881059c629adc88
diff --git a/src/Reader/DBA.php b/src/Reader/DBA.php
@@ -26,7 +26,7 @@
  */
 class DBA extends Reader {
 	/**
-	 * The file handle
+	 * @var resource|false|null The file handle
 	 */
 	protected $handle;
 
diff --git a/src/Writer/PHP.php b/src/Writer/PHP.php
@@ -30,14 +30,17 @@
  */
 class PHP extends Writer {
 	/**
-	 * The file handle
+	 * @var resource|false|null The file handle
 	 */
 	protected $handle;
 
-	protected $hplist;
+	/** @var int[][] */
+	protected $hplist = [];
 
-	protected $numentries;
+	/** @var int */
+	protected $numentries = 0;
 
+	/** @var int */
 	protected $pos;
 
 	/**
@@ -53,8 +56,6 @@ public function __construct( string $fileName ) {
 			$this->throwException(
 				'Unable to open CDB file "' . $this->tmpFileName . '" for write.' );
 		}
-		$this->hplist = [];
-		$this->numentries = 0;
 		$this->pos = 2048; // leaving space for the pointer array, 256 * 8
 		if ( fseek( $this->handle, $this->pos ) == -1 ) {
 			$this->throwException( 'fseek failed in file "' . $this->tmpFileName . '".' );
