build: Updating mediawiki/mediawiki-codesniffer to 37.0.0

libraryupgrader · libraryupgrader · commit 3e721508abf0 · 2021-07-22T02:45:10.000Z
Change-Id: I94deb0cd5fccbfe5b6b943793206c256447619a0
diff --git a/composer.json b/composer.json
@@ -29,7 +29,7 @@
 		"php": ">=7.2.9"
 	},
 	"require-dev": {
-		"mediawiki/mediawiki-codesniffer": "36.0.0",
+		"mediawiki/mediawiki-codesniffer": "37.0.0",
 		"mediawiki/minus-x": "1.1.1",
 		"ockcyp/covers-validator": "1.3.3",
 		"php-parallel-lint/php-console-highlighter": "0.5.0",
diff --git a/src/Cli.php b/src/Cli.php
@@ -76,7 +76,7 @@ public function run() {
 		}
 	}
 
-	private function runGet() : void {
+	private function runGet(): void {
 		if ( count( $this->params ) !== 1 ) {
 			$this->error( "The 'get' action requires one parameter." );
 			return;
@@ -92,7 +92,7 @@ private function runGet() : void {
 		$this->output( $value );
 	}
 
-	private function runList() : void {
+	private function runList(): void {
 		if ( count( $this->params ) > 1 ) {
 			$this->error( "The 'list' action accepts only one parameter." );
 			return;
@@ -112,7 +112,7 @@ private function runList() : void {
 		}
 	}
 
-	private function runMatch() : void {
+	private function runMatch(): void {
 		if ( count( $this->params ) !== 1 ) {
 			$this->error( "The 'match' action requires one parameter." );
 			return;
@@ -133,7 +133,7 @@ private function runMatch() : void {
 		}
 	}
 
-	private function help() : void {
+	private function help(): void {
 		$this->output( <<<TEXT
 usage: {$this->self} <file> [<action>=list] [<parameters...>]
 
@@ -146,17 +146,17 @@ private function help() : void {
 		);
 	}
 
-	private function error( string $text ) : void {
+	private function error( string $text ): void {
 		$this->exitCode = 1;
 		$this->output( "\nerror: $text\n------\n" );
 		$this->help();
 	}
 
-	private function output( string $text ) : void {
+	private function output( string $text ): void {
 		fwrite( $this->out, $text . "\n" );
 	}
 
-	public function getExitCode() : int {
+	public function getExitCode(): int {
 		return $this->exitCode;
 	}
 }
diff --git a/tests/CdbTest.php b/tests/CdbTest.php
@@ -8,7 +8,7 @@ class CdbTest extends \PHPUnit\Framework\TestCase {
 	/** @var string */
 	private $phpCdbFile, $dbaCdbFile;
 
-	protected function setUp() : void {
+	protected function setUp(): void {
 		parent::setUp();
 		if ( !Reader::haveExtension() ) {
 			$this->markTestSkipped( 'Native CDB support is not available.' );
@@ -21,7 +21,7 @@ protected function setUp() : void {
 		$this->dbaCdbFile = tempnam( $temp, get_class( $this ) . '_' );
 	}
 
-	protected function tearDown() : void {
+	protected function tearDown(): void {
 		unlink( $this->phpCdbFile );
 		unlink( $this->dbaCdbFile );
 		parent::tearDown();
diff --git a/tests/CliTest.php b/tests/CliTest.php
@@ -10,7 +10,7 @@ class CliTest extends \PHPUnit\Framework\TestCase {
 	private const FIXTURE = __DIR__ . '/fixture/example.cdb';
 	private $out;
 
-	protected function setUp() : void {
+	protected function setUp(): void {
 		$this->out = fopen( 'php://memory', 'rw' );
 	}
 
diff --git a/tests/Reader/DBATest.php b/tests/Reader/DBATest.php
@@ -10,7 +10,7 @@
  */
 class DBATest extends \PHPUnit\Framework\TestCase {
 
-	protected function setUp() : void {
+	protected function setUp(): void {
 		parent::setUp();
 		if ( !Reader::haveExtension() ) {
 			$this->markTestSkipped( 'Native CDB support is not available.' );
diff --git a/tests/Reader/PHPTest.php b/tests/Reader/PHPTest.php
@@ -11,7 +11,7 @@ class PHPTest extends \PHPUnit\Framework\TestCase {
 	/** @var string */
 	private $cdbFile;
 
-	protected function setUp() : void {
+	protected function setUp(): void {
 		parent::setUp();
 		$temp = sys_get_temp_dir();
 		if ( !is_writable( $temp ) ) {
@@ -20,7 +20,7 @@ protected function setUp() : void {
 		$this->cdbFile = tempnam( $temp, get_class( $this ) . '_' );
 	}
 
-	protected function tearDown() : void {
+	protected function tearDown(): void {
 		unlink( $this->cdbFile );
 		parent::tearDown();
 	}

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ public function run() {`
`76`	`76`	`}`
`77`	`77`	`}`
`78`	`78`
`79`		`- private function runGet() : void {`
	`79`	`+ private function runGet(): void {`
`80`	`80`	`if ( count( $this->params ) !== 1 ) {`
`81`	`81`	`$this->error( "The 'get' action requires one parameter." );`
`82`	`82`	`return;`
`@@ -92,7 +92,7 @@ private function runGet() : void {`
`92`	`92`	`$this->output( $value );`
`93`	`93`	`}`
`94`	`94`
`95`		`- private function runList() : void {`
	`95`	`+ private function runList(): void {`
`96`	`96`	`if ( count( $this->params ) > 1 ) {`
`97`	`97`	`$this->error( "The 'list' action accepts only one parameter." );`
`98`	`98`	`return;`
`@@ -112,7 +112,7 @@ private function runList() : void {`
`112`	`112`	`}`
`113`	`113`	`}`
`114`	`114`
`115`		`- private function runMatch() : void {`
	`115`	`+ private function runMatch(): void {`
`116`	`116`	`if ( count( $this->params ) !== 1 ) {`
`117`	`117`	`$this->error( "The 'match' action requires one parameter." );`
`118`	`118`	`return;`
`@@ -133,7 +133,7 @@ private function runMatch() : void {`
`133`	`133`	`}`
`134`	`134`	`}`
`135`	`135`
`136`		`- private function help() : void {`
	`136`	`+ private function help(): void {`
`137`	`137`	`$this->output( <<<TEXT`
`138`	`138`	`usage: {$this->self} <file> [<action>=list] [<parameters...>]`
`139`	`139`
`@@ -146,17 +146,17 @@ private function help() : void {`
`146`	`146`	`);`
`147`	`147`	`}`
`148`	`148`
`149`		`- private function error( string $text ) : void {`
	`149`	`+ private function error( string $text ): void {`
`150`	`150`	`$this->exitCode = 1;`
`151`	`151`	`$this->output( "\nerror: $text\n------\n" );`
`152`	`152`	`$this->help();`
`153`	`153`	`}`
`154`	`154`
`155`		`- private function output( string $text ) : void {`
	`155`	`+ private function output( string $text ): void {`
`156`	`156`	`fwrite( $this->out, $text . "\n" );`
`157`	`157`	`}`
`158`	`158`
`159`		`- public function getExitCode() : int {`
	`159`	`+ public function getExitCode(): int {`
`160`	`160`	`return $this->exitCode;`
`161`	`161`	`}`
`162`	`162`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ class CliTest extends \PHPUnit\Framework\TestCase {`
`10`	`10`	`private const FIXTURE = __DIR__ . '/fixture/example.cdb';`
`11`	`11`	`private $out;`
`12`	`12`
`13`		`- protected function setUp() : void {`
	`13`	`+ protected function setUp(): void {`
`14`	`14`	`$this->out = fopen( 'php://memory', 'rw' );`
`15`	`15`	`}`
`16`	`16`