Dramatically reduce total number of method calls in PHP writer

thiemowmde · thiemowmde · commit 0e1b92e04ea9 · 2022-11-07T17:11:31.000Z
This does have an actual impact on the runtime of code that uses this,
e.g. MessageIndexTest in the Translate extension.

Change-Id: I67a1b060960f4102379632350f1ecba055e5211c
diff --git a/src/Writer/PHP.php b/src/Writer/PHP.php
@@ -72,8 +72,7 @@ public function set( $key, $value ): void {
 			return;
 		}
 		$this->addbegin( strlen( $key ), strlen( $value ) );
-		$this->write( $key );
-		$this->write( $value );
+		$this->write( $key . $value );
 		$this->addend( strlen( $key ), strlen( $value ), Util::hash( $key ) );
 	}
 
@@ -126,9 +125,7 @@ protected function addend( $keylen, $datalen, $h ) {
 		];
 
 		$this->numentries++;
-		$this->posplus( 8 );
-		$this->posplus( $keylen );
-		$this->posplus( $datalen );
+		$this->posplus( 8 + $keylen + $datalen );
 	}
 
 	/**
@@ -207,14 +204,15 @@ protected function finish(): void {
 			}
 
 			// Write the hashtable
+			$buf = '';
 			for ( $u = 0; $u < $len; ++$u ) {
-				$buf = pack( 'vvV',
+				$buf .= pack( 'vvV',
 					$hashtable[$u]['h'] & 0xffff,
 					Util::unsignedShiftRight( $hashtable[$u]['h'], 16 ),
 					$hashtable[$u]['p'] );
-				$this->write( $buf );
-				$this->posplus( 8 );
 			}
+			$this->write( $buf );
+			$this->posplus( strlen( $buf ) );
 		}
 
 		// Write the pointer array at the start of the file

Original file line number	Diff line number	Diff line change
`@@ -72,8 +72,7 @@ public function set( $key, $value ): void {`
`72`	`72`	`return;`
`73`	`73`	`}`
`74`	`74`	`$this->addbegin( strlen( $key ), strlen( $value ) );`
`75`		`- $this->write( $key );`
`76`		`- $this->write( $value );`
	`75`	`+ $this->write( $key . $value );`
`77`	`76`	`$this->addend( strlen( $key ), strlen( $value ), Util::hash( $key ) );`
`78`	`77`	`}`
`79`	`78`
`@@ -126,9 +125,7 @@ protected function addend( $keylen, $datalen, $h ) {`
`126`	`125`	`];`
`127`	`126`
`128`	`127`	`$this->numentries++;`
`129`		`- $this->posplus( 8 );`
`130`		`- $this->posplus( $keylen );`
`131`		`- $this->posplus( $datalen );`
	`128`	`+ $this->posplus( 8 + $keylen + $datalen );`
`132`	`129`	`}`
`133`	`130`
`134`	`131`	`/**`
`@@ -207,14 +204,15 @@ protected function finish(): void {`
`207`	`204`	`}`
`208`	`205`
`209`	`206`	`// Write the hashtable`
	`207`	`+ $buf = '';`
`210`	`208`	`for ( $u = 0; $u < $len; ++$u ) {`
`211`		`- $buf = pack( 'vvV',`
	`209`	`+ $buf .= pack( 'vvV',`
`212`	`210`	`$hashtable[$u]['h'] & 0xffff,`
`213`	`211`	`Util::unsignedShiftRight( $hashtable[$u]['h'], 16 ),`
`214`	`212`	`$hashtable[$u]['p'] );`
`215`		`- $this->write( $buf );`
`216`		`- $this->posplus( 8 );`
`217`	`213`	`}`
	`214`	`+ $this->write( $buf );`
	`215`	`+ $this->posplus( strlen( $buf ) );`
`218`	`216`	`}`
`219`	`217`
`220`	`218`	`// Write the pointer array at the start of the file`