build: Updating mediawiki/mediawiki-codesniffer to 37.0.0

libraryupgrader · libraryupgrader · commit 98a9a1bdd171 · 2021-07-22T02:24:41.000Z
Change-Id: Iae8caf3500a49001fe2727fd0c1ef62b378c7093
diff --git a/composer.json b/composer.json
@@ -27,7 +27,7 @@
 		"php": ">=7.2.9"
 	},
 	"require-dev": {
-		"mediawiki/mediawiki-codesniffer": "36.0.0",
+		"mediawiki/mediawiki-codesniffer": "37.0.0",
 		"mediawiki/mediawiki-phan-config": "0.10.6",
 		"mediawiki/minus-x": "1.1.1",
 		"ockcyp/covers-validator": "1.3.3",
diff --git a/src/Converter.php b/src/Converter.php
@@ -99,7 +99,7 @@ class Converter {
 	 * @param string $rule The rule to convert
 	 * @return string The RPN representation of the rule
 	 */
-	public static function convert( $rule ) : string {
+	public static function convert( $rule ): string {
 		$parser = new self( $rule );
 
 		return $parser->doConvert();
@@ -120,7 +120,7 @@ protected function __construct( string $rule ) {
 	 *
 	 * @return string The RPN representation of the rule (e.g. "5 3 mod n is")
 	 */
-	protected function doConvert() : string {
+	protected function doConvert(): string {
 		$expectOperator = true;
 
 		// Iterate through all tokens, saving the operators and operands to a
@@ -308,7 +308,7 @@ protected function doOperation( Operator $op ) {
 	 * @param int $pos
 	 * @return Expression The numerical expression
 	 */
-	protected function newNumber( string $text, int $pos ) : Expression {
+	protected function newNumber( string $text, int $pos ): Expression {
 		return new Expression( $this, 'number', $text, $pos, strlen( $text ) );
 	}
 
@@ -320,7 +320,7 @@ protected function newNumber( string $text, int $pos ) : Expression {
 	 * @param int $length
 	 * @return Operator The operator
 	 */
-	protected function newOperator( string $type, int $pos, int $length ) : Operator {
+	protected function newOperator( string $type, int $pos, int $length ): Operator {
 		return new Operator( $this, $type, $pos, $length );
 	}
 
diff --git a/src/Converter/Expression.php b/src/Converter/Expression.php
@@ -39,7 +39,7 @@ public function __construct( Converter $parser, $type, $rpn, $pos, $length ) {
 	 * @param string $type
 	 * @return bool
 	 */
-	public function isType( $type ) : bool {
+	public function isType( $type ): bool {
 		if ( $type === 'range' && ( $this->type === 'range' || $this->type === 'number' ) ) {
 			return true;
 		}
diff --git a/src/Converter/Operator.php b/src/Converter/Operator.php
@@ -88,7 +88,7 @@ public function __construct( Converter $parser, $name, $pos, $length ) {
 	 * @param Expression $right The right part of the expression
 	 * @return Expression The result of the operation
 	 */
-	public function operate( Expression $left, Expression $right ) : Expression {
+	public function operate( Expression $left, Expression $right ): Expression {
 		$typeSpec = self::OP_TYPES[$this->name];
 
 		$leftType = self::TYPE_SPEC_MAP[$typeSpec[0]];
diff --git a/src/Evaluator.php b/src/Evaluator.php
@@ -36,7 +36,7 @@ public static function evaluate( $number, array $rules ) {
 	 * @param array $rules The rules to compile
 	 * @return array An array of compile rules.
 	 */
-	public static function compile( array $rules ) : array {
+	public static function compile( array $rules ): array {
 		// We can't use array_map() for this because it generates a warning if
 		// there is an exception.
 		foreach ( $rules as &$rule ) {
@@ -55,7 +55,7 @@ public static function compile( array $rules ) : array {
 	 * @param array $rules The associative array of plural rules in pluralform => rule format.
 	 * @return int The index of the plural form which passed the evaluation
 	 */
-	public static function evaluateCompiled( $number, array $rules ) : int {
+	public static function evaluateCompiled( $number, array $rules ): int {
 		// Calculate the values of the operand symbols
 		$number = strval( $number );
 		if ( !preg_match( '/^ -? ( ([0-9]+) (?: \. ([0-9]+) )? )$/x', $number, $m ) ) {
diff --git a/src/Range.php b/src/Range.php
@@ -41,7 +41,7 @@ public function __construct( $start, $end = false ) {
 	 *   otherwise, number simply has to be inside the range.
 	 * @return bool True if the number is inside the range; otherwise, false.
 	 */
-	public function isNumberIn( $number, $integerConstraint = true ) : bool {
+	public function isNumberIn( $number, $integerConstraint = true ): bool {
 		foreach ( $this->parts as $part ) {
 			if ( is_array( $part ) ) {
 				if ( ( !$integerConstraint || floor( $number ) === (float)$number )
@@ -66,7 +66,7 @@ public function isNumberIn( $number, $integerConstraint = true ) : bool {
 	 * @param int $number The number to check
 	 * @return bool True if the number is inside the range; otherwise, false.
 	 */
-	public function isNumberWithin( $number ) : bool {
+	public function isNumberWithin( $number ): bool {
 		return $this->isNumberIn( $number, false );
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ public function __construct( Converter $parser, $type, $rpn, $pos, $length ) {`
`39`	`39`	`* @param string $type`
`40`	`40`	`* @return bool`
`41`	`41`	`*/`
`42`		`- public function isType( $type ) : bool {`
	`42`	`+ public function isType( $type ): bool {`
`43`	`43`	`if ( $type === 'range' && ( $this->type === 'range' \|\| $this->type === 'number' ) ) {`
`44`	`44`	`return true;`
`45`	`45`	`}`