Add an option to limit results with Elastica #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank for this, @odolbeau. I'm sorry there's been no activity from us here. Please could you add something to the Elastica section in the README explaining this new option? This will then be good to merge, I think. |
odolbeau
force-pushed
the
limit-es-results
branch
from
28c49da to
b4a5448
Compare
Author
|
PR rebased! 👍 |
sampart
requested changes
May 17, 2018
Collaborator
sampart
left a comment
sampart
left a comment
There was a problem hiding this comment.
Thanks for this. Just one last change.
|
|
||
| *Be careful when paginating a huge set of documents. By default, offset + limit | ||
| can't exceed 10000. For more information, see: | ||
| [#213](https://github.com/whiteoctober/Pagerfanta/pull/213#issue-87631892).* |
Collaborator
There was a problem hiding this comment.
Could you add an additional sentence saying something like "You can mitigate this by setting the $maxResults parameter when constructing the ElasticaAdapter"? Thanks
odolbeau
force-pushed
the
limit-es-results
branch
from
b4a5448 to
cb95185
Compare
Author
|
Done |
Collaborator
|
I'll merge once tests have passed. |
Collaborator
|
I've created release https://github.com/whiteoctober/Pagerfanta/releases/tag/v2.0.1 for this. Thanks again for your input. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With recent ES version, we have en exception when size + offset > 10000.
BTW it's possible to override this directly in ES configuration even if it's not recommended.
With this new constructor argument, it's possible to limit the number of results even if the dataset contains more results.
In this case, we won't display pages where size + offset > 10000 and we won't have this error: