Skip to content

Compare popover attribute states consistently - #13127

Open
JinDX wants to merge 1 commit into
whatwg:mainfrom
JinDX:fix/popover-state-comparison
Open

JinDX wants to merge 1 commit into
whatwg:mainfrom
JinDX:fix/popover-state-comparison

Conversation

@JinDX

@JinDX JinDX commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

Compare originalType with the current state of the popover attribute. originalType is initialized from the attribute state, but the later guard currently compares it with the attribute value.

This keeps the guard meaningful for values such as the empty string that map to the Auto state.

Suggested regression coverage: equivalent attribute spellings and state changes caused by beforetoggle handlers while other popovers are hidden.

Spec: https://html.spec.whatwg.org/multipage/popover.html#show-popover

  • At least two implementers are interested (and none opposed):
    • …
    • …
  • Tests are written and can be reviewed and commented upon at:
    • …
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
    • Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): …
    • Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): …
  • Corresponding HTML AAM & ARIA in HTML issues & PRs:
  • MDN issue is filed: …
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)


/popover.html ( diff )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant