Repository navigation
[autofocus] Remove cross-origin check step for autofocus candidates - #11277
Conversation
|
cc @dandclark |
|
Thank you! This looks good to me, but we should add some test coverage for the combination of this permission policy and Also, I suspect you work for Microsoft? Please join the relevant GitHub organization to satisfy the IPR bot. |
|
Hi @annevk, thanks for your review! There are already a couple WPT tests about the interaction of autofocus with the permissions policy here: https://github.com/web-platform-tests/wpt/blob/master/permissions-policy/experimental-features/focus-without-user-activation-disabled.html Do you think this is enough coverage? (btw thanks for mentioning the organization issue, I'm in the process of adding it) |
|
That appears sufficient, yes. In that case I think we should just consider this a bug fix on top of the original PR. You will need to address the Participation CI check though. |
|
Thanks @annevk, I just managed to solve the Participation issue. Now it seems like all checks pass. |
|
Thanks! |
This PR addresses issue #11276. Step 6 in the algorithm for filtering autofocus candidates is not needed anymore after the addition of 'allow focus steps' in step 5 that checks if the element belongs to an element that allows the feature policy focus-without-user-activation, i.e. if an element is in a frame that allows the policy with *, then it should allow autofocus even if it's from a different origin.
/interaction.html ( diff )