WIP: Default weight unit#1181
Conversation
|
Its been a while since I've done any dart and Riverpod is all new to me so I'm not sure if this is the right way to handle the provider setup. I did not think it made sense to refactor all the providers needed for RoutineProvider to be fully Riverpod in a single pull request. I'm also looking for feedback on the set_config_data changes. I personally don't think DTO like objects should be selecting a default value for a field that is indicated as null-able, but it seems like an established pattern here. If this change goes forward, does it make sense to also refactor the recent log changes here? |
|
Hi! Sorry for the late reply. There's another PR that I'm working on that is migrating the providers to riverpod, so that problem will disappear in the future. And as for the PR, I'm not sure if making the plate calculator the source of truth is the correct way. There is already a flag in the profile that handles this (but as you've probably noticed, hasn't the biggest impact in the app) and I would tend to use that (also for the initial value for the plate calculator itself). |
Initial PR to solicit feedback
Proposed Changes
Related Issue(s)
Closes #1180
Please check that the PR fulfills these requirements
dart format .)