Suggestion for 'people' array of day 4#406
Merged
wesbos merged 2 commits intowesbos:masterfrom Oct 20, 2020
Merged
Conversation
The original order was the same at the solution to exercise 7 in the file, thus I think the difference couldn't be seen properly.
The original order was the same at the solution to exercise 7 in the file, thus I think the difference couldn't be seen properly.
Owner
|
good idea! I like it. Thanks for this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Wes,
Thank you very much for this awesome course, I'm learning a lot from it!
I understand the video/code might not be updated in order to keep things consistent, but I'd still like to propose this small change. In the current version of the source code the order of items in the 'people' array is the same as that of the output of exercise 7, thus the difference is not quite visible, in my opinion. Maybe it would make sense even without a video update?
Thank you for your consideration!
Best,
Lilla Pulay