createObjectURL() has been depreceated.#239
Merged
wesbos merged 2 commits intowesbos:masterfrom Sep 24, 2018
prakhars17:patch-1
Merged
createObjectURL() has been depreceated.#239wesbos merged 2 commits intowesbos:masterfrom prakhars17:patch-1
wesbos merged 2 commits intowesbos:masterfrom
prakhars17:patch-1
Conversation
replaced createObjectURL() with newer syntax.
palashmon
reviewed
Sep 16, 2018
19 - Webcam Fun/scripts-FINISHED.js
Outdated
| // DEPRECIATION : | ||
| // The following has been depreceated by major browsers. | ||
| // video.src = window.URL.createObjectURL(localMediaStream); | ||
| // Please refer to this: |
Collaborator
There was a problem hiding this comment.
Hi, thanks for your contribution. But I think you forgot to add the link in comments which one can refer to for further information about createObjectURL depreciation.
Regards!
Contributor
Author
|
Thanks, @palashmon. Updated with the relevant links. |
Collaborator
|
Awesome! |
Owner
|
thank you - I like how you added the comment in so it doesn't kill the video :D |
cbtsao47
pushed a commit
to cbtsao47/JavaScript30
that referenced
this pull request
Nov 23, 2018
createObjectURL() has been depreceated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced createObjectURL() with newer syntax.
Well, if this PR is merged, it may be slightly different(only a single line) from the videos as createObjectURL() has been deprecated by major browsers. Just alerting @wesbos and others if not aware.