fix: Use valid code to trick WP-CLI 2.12+#141
Merged
gmazzap merged 1 commit intowecodemore:devfrom May 12, 2025
Merged
Conversation
From 2.12, WP-CLI uses a more accurate regex to check that `wp-settings.php` has been required. See: - wp-cli/wp-cli#6039 - wp-cli/wp-cli#6042
nlemoine
added a commit
to Humanoidfr/wpstarter
that referenced
this pull request
May 12, 2025
gmazzap
approved these changes
May 12, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The latest WP-CLI version isn't tricked so easily anymore by singing "ob-la-di, ob-la-da life goes on, brah" 🙂
wpstarter/templates/wp-config-loader.php
Lines 13 to 27 in 6ff8cab
It now triggers an error:
See the relevant PR:s
wp-settings.phpwp-cli/wp-cli#6039wp-settings.phpcall is loaded wp-cli/wp-cli#6042The checks against
require wp-settings.phphave been enforced so its now needs to actual valid code.How has this been tested?
Locally using WP-CLI 2.12.
Types of changes
A tiny change in
wp-configPHP comment.Bug fixes (non-breaking change which fixes an issue)
Checklist: