Conversation
|
Hello, @alexander-akait @snitin315 can you check if this change suits issue #3689 ? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5441 +/- ##
==========================================
- Coverage 83.40% 82.87% -0.54%
==========================================
Files 13 13
Lines 2031 2149 +118
Branches 749 769 +20
==========================================
+ Hits 1694 1781 +87
- Misses 303 327 +24
- Partials 34 41 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexander-akait
left a comment
There was a problem hiding this comment.
Let's add a test cases.
You remove:
containerElement.innerHTML = overlayTrustedTypesPolicy
? overlayTrustedTypesPolicy.createHTML("")
: "";
But in some part of code you use something.innerHTML= "html", you need to use the same logic as you remove, otherwise trusted police will be broken
Also does it work for warnings too?
|
Anyway code looks good, let's fix the problems above |
|
Hello, @alexander-akait. I have modified the code according to the above suggestions. can you verify if it is sufficient? |
alexander-akait
left a comment
There was a problem hiding this comment.
Let's add the same test but with TrustedTypesPolicy to ensure we don't break something and we can merge, thank you for your work
|
Hello, @alexander-akait I have added another test cases with same functionality for P.S. Iam unsure on what steps, if any I should take for it. |
|
@negimox Just make rebase, already fixed in master/main |
|
Hello @alexander-akait, I’ve rebased this branch onto the latest changes. Let me know if there’s anything else you’d like me to address here. Have a great weekend! |
|
@negimox And also can you update snapshots, because in our test we still have old HTML output, thank you |
alexander-akait
left a comment
There was a problem hiding this comment.
Let's fix a lint problem and does it work with warnings too?
|
Sorry for delay |
|
Hey @alexander-akait 😅 — I'm also quite late to this, my apologies!
Got it — I’ll update the snapshots accordingly.
Yes, it should work with warnings as well, but I’ll double-check and verify that to be sure. |
|
@negimox Feel free update and we can merge |
|
Hello @alexander-akait, hope you are doing well. Could you point me as to how can I resolve this error? Additionally, I've made improvements to the UI to better align with the reference images and ensure better responsiveness on smaller screen sizes.
P.S. I tested and it is working with warning as well. Video.06-29-2025.23.18.22.mp4Let me know if there are still any changes that need to be made. |
For Bugs and Features; did you add new tests?
No ( Already exists )
Motivation / Use-Case
Modified and improved the overlay UI according to #3689
Breaking Changes
Additional Info
webpack_dev_feat_overlay-2025-03-23_03.09.36.mp4