Conversation
snitin315
requested review from
alexander-akait,
anshumanv,
hiroppy and
knagaitsev
as code owners
| ] | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
hm, so chokidar doesn't validate own options?
There was a problem hiding this comment.
@alexander-akait No, it doesn't.
Screen.Recording.2022-05-03.at.7.29.08.AM.mov
There was a problem hiding this comment.
hmm, I think we allow some extra options for watching, but chokidar will only understand its API options.
webpack-dev-server/lib/Server.js
Lines 766 to 772 in c2fee3b
webpack-dev-server/lib/Server.js
Line 805 in c2fee3b
There was a problem hiding this comment.
weird, there are problem when new options will be added, in this case we will need to add them too, it is not good
There was a problem hiding this comment.
Yeah, ideally chokidar should have its own validation. Maybe we can add an option in scema-utils additionalProperties: "warn" which will warn if you use another property instead of throwing an error and exiting the process.
There was a problem hiding this comment.
Sounds better, we will still needed update them when new options were added, but it happens rarely
snitin315
force-pushed
the
schema-additional-props
branch
from
b36b0c7 to
ae2312b
Compare
Codecov Report
@@ Coverage Diff @@
## master #4424 +/- ##
=======================================
Coverage 92.42% 92.42%
=======================================
Files 16 16
Lines 1597 1597
Branches 598 598
=======================================
Hits 1476 1476
Misses 112 112
Partials 9 9 Continue to review full report at Codecov.
|
2 participants
For Bugs and Features; did you add new tests?
Yes.
Motivation / Use-Case
Resolve #4362
Screen.Recording.2022-05-03.at.7.29.34.AM.mov
Breaking Changes
No
Additional Info
No