Skip to content

fix: use correct port for https reverse proxy#4293

Open
qswinson wants to merge 1 commit intowebpack:mainfrom
Ahana-Inc:fix-port
Open

fix: use correct port for https reverse proxy#4293
qswinson wants to merge 1 commit intowebpack:mainfrom
Ahana-Inc:fix-port

Conversation

@qswinson
Copy link

@qswinson qswinson commented Feb 16, 2022

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

New test cases have been added

Motivation / Use-Case

This solves #4292 where the port of the webpack dev server is used instead of the port from the location in https situations.

Breaking Changes

no breaking changes

Additional Info

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 16, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

alexander-akait
alexander-akait reviewed Feb 17, 2022
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is breaking change and breaks URLs for local development

@qswinson
Copy link
Author

qswinson commented Feb 17, 2022

It is breaking change and breaks URLs for local development

Can you provide a test case for the test suite that you say is breaking so I can address it? All of the unit tests are passing. The current behavior is a breaking change from Webpack v4 and is preventing us from upgrading.

@alexander-akait
Copy link
Member

alexander-akait commented Feb 17, 2022 •
edited
Loading

Because you fix it only for 0.0.0.0/etc, it is not valid fix, also other developers can use different ports for proxy, we don't know your proxied port and can't rely on location port (even more it is security problem), you can set https://webpack.js.org/configuration/dev-server/#websocketurl, in your case you can set port: 0, it will be auto -

webpack-dev-server/client-src/utils/createSocketURL.js

Line 143 in 23dc6f4

socketURLPort = self.location.port;
, i.e. what you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-akait alexander-akait alexander-akait left review comments

@hiroppy hiroppy Awaiting requested review from hiroppy

@knagaitsev knagaitsev Awaiting requested review from knagaitsev

@snitin315 snitin315 Awaiting requested review from snitin315

@anshumanv anshumanv Awaiting requested review from anshumanv

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qswinson @alexander-akait