chore: convert dev server to webpack plugin#3850
Conversation
rishabh3112
requested review from
alexander-akait,
anshumanv,
hiroppy,
knagaitsev and
snitin315
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3850 +/- ##
==========================================
- Coverage 92.87% 92.75% -0.13%
==========================================
Files 14 14
Lines 1334 1338 +4
Branches 467 468 +1
==========================================
+ Hits 1239 1241 +2
- Misses 87 89 +2
Partials 8 8
Continue to review full report at Codecov.
|
|
@alexander-akait let me know if there any custom hooks required to be implemented here. |
|
|
||
| let started = false; | ||
|
|
||
| compiler.hooks.watchRun.tapPromise(pluginName, async () => { |
There was a problem hiding this comment.
We should enable watch before taping into watchRun hook.
There was a problem hiding this comment.
Yes, plugin should work only for webpack watch/webpack serve, but I am afraid it is so late to override fs, need think more about it
There was a problem hiding this comment.
Yep, in my roadmap on the next week
2 participants
For Bugs and Features; did you add new tests?
WIP
Motivation / Use-Case
Dev Server should be a plugin
Breaking Changes
Nope
Additional Info
N/A