-
-
Notifications
You must be signed in to change notification settings - Fork 652
fix(add): add handling for topScope #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
Hi @rishabh3112, great job, I confirm the error is gone. I've copied Does it happens to you? If not, I'll try again after cleaning my folders 👍 |
|
@rishabh3112 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evenstensberg Please review the new changes. |
This comment has been minimized.
This comment has been minimized.
rephrase question
|
@misterdev Thanks for reporting 💯 Have rephrased question @evenstensberg & @misterdev 👍 |
|
Works now, well done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
@rishabh3112 Do you mind adding a test for this?
|
Hi @sendilkumarn, Can you guide me here? Currently, we are not testing any of the generators ( also smoke tests for scaffold functions). I would love to add them! |
|
We don't really have a good way to test scaffolds @sendilkumarn |
evenstensberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, nice job!

What kind of change does this PR introduce?
BugFix For #795
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
#795
Does this PR introduce a breaking change?
No
Other information