-
-
Notifications
You must be signed in to change notification settings - Fork 652
tests(migration): including requested changes #765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(migration): including requested changes #765
Conversation
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
If you inside a typescript file, I discorage the use of |
|
Thanks for reviewing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it looks ok, lgtm. 💚
What kind of change does this PR introduce?
Includes changes requested in #613
Summary
Before committing I had to solve those issues:
Removed deprecated
lang: [0, "always", "eng"]from commitlint configuration. It gave me errors preventing me from committing:Fixed a tslint error:
Those are the actual changes:
transformationsinpackages/migrate/migrate.tsmigrate/**/__tests__/**.test.tsAdds a type notation in
packages/utils/__tests__/ast-utils.test.tsI've also refactored
packages/migrate/resolve/__tests__/__testfixtures__/resolve.input.jsfollowing this comment.There's something I don't understand well, changing
const path = require("path")withconst {resolve} = require("path")gives me an error:Why does this happens?
Feedbacks are welcome :)