Merged
Conversation
dhruvdutt
reviewed
Jun 15, 2018
Contributor
dhruvdutt
left a comment
dhruvdutt
left a comment
There was a problem hiding this comment.
Can you please change base branch to next? Having master ahead of next would cause next to rebase and force push every time master gets ahead.
Member
Author
|
This is kinda a high priority, so we can't delay this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #495
Did you add tests for your changes?
N/a
If relevant, did you update the documentation?
Yes
Summary
Adds a changelog for v3
Does this PR introduce a breaking change?
no
Other information
=)