Skip to content

ci: add Node.js v20#3739

Merged
alexander-akait merged 5 commits intomasterfrom
snitin315-patch-1
Jun 1, 2023
Merged

ci: add Node.js v20#3739
alexander-akait merged 5 commits intomasterfrom
snitin315-patch-1

Conversation

@snitin315
Copy link
Member

@snitin315 snitin315 commented Apr 19, 2023

What kind of change does this PR introduce?

Did you add tests for your changes?

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

@snitin315 snitin315 requested a review from a team as a code owner April 19, 2023 01:12
@codecov
Copy link

codecov bot commented Apr 19, 2023 •
edited
Loading

Codecov Report

Merging #3739 (394d0cd) into master (6344b47) will decrease coverage by 32.80%.
The diff coverage is n/a.

❗ Current head 394d0cd differs from pull request most recent head 61e4072. Consider uploading reports for the commit 61e4072 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #3739       +/-   ##
===========================================
- Coverage   91.64%   58.84%   -32.80%     
===========================================
  Files          22        9       -13     
  Lines        1628     1198      -430     
  Branches      466      381       -85     
===========================================
- Hits         1492      705      -787     
- Misses        136      493      +357

see 19 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6344b47...61e4072. Read the comment docs.

@alexander-akait
Copy link
Member

alexander-akait commented Apr 19, 2023

Hm, do we have deprecations output there?

@snitin315
Copy link
Member Author

snitin315 commented Apr 19, 2023

I'll check this locally.

@alexander-akait
Copy link
Member

alexander-akait commented Apr 21, 2023

magic 🧙 locally all works perfectly

@snitin315
Copy link
Member Author

snitin315 commented Apr 21, 2023

There is a bug report in v20 nodejs/node#47614. It may be related.

@alexander-akait
Copy link
Member

alexander-akait commented Apr 21, 2023

@snitin315 hm, I don't think, because it works locally using node v20 on ubuntu

@alexander-akait
Copy link
Member

alexander-akait commented May 31, 2023

Problem with nyc here... trying to solve it

@alexander-akait
Copy link
Member

alexander-akait commented May 31, 2023

Merging #3739 (394d0cd) into master (6344b47) will decrease coverage by 32.80%.

Not good...

@alexander-akait alexander-akait mentioned this pull request May 31, 2023
Closed
@alexander-akait alexander-akait merged commit 1e9e946 into master Jun 1, 2023
@alexander-akait alexander-akait deleted the snitin315-patch-1 branch June 1, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees

No one assigned

Labels

PR: reviewed-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@snitin315 @alexander-akait @webpack-bot