fix: broken serve with new CLI API#2770
Merged
alexander-akait merged 1 commit intomasterfrom Jun 7, 2021
Merged
Conversation
snitin315
approved these changes
Jun 7, 2021
anshumanv
approved these changes
Jun 7, 2021
Codecov Report
@@ Coverage Diff @@
## master #2770 +/- ##
==========================================
- Coverage 94.16% 94.10% -0.06%
==========================================
Files 31 31
Lines 1679 1680 +1
Branches 488 489 +1
==========================================
Hits 1581 1581
- Misses 98 99 +1
Continue to review full report at Codecov.
|
jamesgeorge007
pushed a commit
to jamesgeorge007/webpack-cli
that referenced
this pull request
Jun 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix, my mistake, check will be bad for webpack v4 and webpack-dev-server the next version
Did you add tests for your changes?
Latest, but we will have these test in webpack-dev-server
If relevant, did you update the documentation?
No need
Summary
Fix new CLI API
Does this PR introduce a breaking change?
No
Other information
I will do the new patch release after merge