tests: add tests for project root finder util#1483
tests: add tests for project root finder util#1483alexander-akait merged 4 commits intowebpack:nextfrom
Conversation
|
@rishabh3112 init tests seem to fail for some reason, when I was debugging it yesterday it seems that we're checking yarn.lock file too soon before it's created. You can follow - #1478 |
|
@anshumanv the reason you specified isn't possible as currently You may add debug logs to check which files are created while we are testing the existance of |
Already did in plugin PR, yarn.lock wasn't found and no package-lock wasn't created either, I think there's some IO gap in the time it takes to write the file on disk and we may be checking before that. |
|
This is happening in several PRs, you can check those too |
|
For example check here - #1480 @rishabh3112 |
That is only possible if yarn exits its install process without waiting for Anyway, to find actual reason,
Hope this helps :) |
Did all of that already at #1478
The process completes, no issue with process, once you remove yarn.lock from tests, it passes which is strange and led me to conclude that it's an IO problem, 😕
No major changes |
db045c2 to
fe222a9
Compare
fe222a9 to
301f50d
Compare
|
CI still broken 😞 |
|
Checking @evilebottnawi 😄 |
|
/cc @evilebottnawi |
What kind of change does this PR introduce?
Test
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Does this PR introduce a breaking change?
No
Other information
Any suggestions are appreciated.