Skip to content

Reduce allocations and redundant work across compiler hot paths - #21516

Merged
alexander-akait merged 2 commits into
mainfrom
perf/compiler-hotpath-allocations
Jul 26, 2026
Merged

Reduce allocations and redundant work across compiler hot paths#21516
alexander-akait merged 2 commits into
mainfrom
perf/compiler-hotpath-allocations

Conversation

@alexander-akait

Copy link
Copy Markdown
Member

Summary

Behavior-preserving allocation and redundant-work reductions on several compiler hot paths: code generation, module concatenation, exports/usage analysis, module hashing, and chunk splitting. The largest effect is on reexport/barrel-heavy graphs — ExportsInfo.findTarget no longer allocates a Set per call (_findTarget only reads it), isStarReexportBackToParent allocates its visited set lazily, and getStarReexports/setTarget drop throwaway copies — for ~21% fewer GC events on a reexport-heavy full build in local CPU/heap profiling. The rest are smaller idiomatic reductions (InitFragment index-sort + numeric keyless keys, Template.getModulesArrayBounds arithmetic digit count, ConcatenatedModule single Map lookups, hoisted loop invariants, and removal of the dead reusableChunks set in SplitChunksPlugin). Retained heap is unchanged. CI CodSpeed should give a controlled instruction-count measurement.

What kind of change does this PR introduce?

perf

Did you add tests for your changes?

No — these are behavior-preserving refactors, so no new behavior to test. Correctness is covered by the existing suite: full ConfigTestCases (8668 cases, 548 snapshots), TestCasesProduction, and the CSS/HTML/exports unit tests all pass, and yarn tsc is clean.

Does this PR introduce a breaking change?

No.

If relevant, what needs to be documented once your changes are merged or what have you already documented?

n/a

Use of AI

Yes. Claude (Claude Code) was used to CPU- and heap-profile representative builds, identify the hot paths, implement the changes, and measure them with isolated micro-benchmarks and full-build GC-event A/B runs. Every change was validated against the full test suite and type checker before submitting.


Generated by Claude Code

Copilot AI review requested due to automatic review settings July 26, 2026 16:07
@changeset-bot

changeset-bot Bot commented Jul 26, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 275301d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
webpack Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

This PR is packaged and the instant preview is available (fbcbe3e).

Install it locally:

  • npm
npm i -D webpack@https://pkg.pr.new/webpack@fbcbe3e
  • yarn
yarn add -D webpack@https://pkg.pr.new/webpack@fbcbe3e
  • pnpm
pnpm add -D webpack@https://pkg.pr.new/webpack@fbcbe3e

@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.67442% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.78%. Comparing base (9d01716) to head (275301d).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lib/ChunkGraph.js 71.42% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #21516   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files         620      620           
  Lines       73703    73741   +38     
  Branches    21262    21279   +17     
=======================================
+ Hits        69123    69161   +38     
  Misses       4580     4580           
Flag Coverage Δ
css-parsing 25.54% <13.95%> (-0.01%) ⬇️
html5lib 26.98% <22.09%> (+<0.01%) ⬆️
integration 89.58% <97.67%> (+<0.01%) ⬆️
test262 43.31% <70.93%> (+0.01%) ⬆️
unit 47.46% <20.93%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexander-akait
alexander-akait force-pushed the perf/compiler-hotpath-allocations branch from f7cd524 to 049e57d Compare July 26, 2026 16:27
Copilot AI review requested due to automatic review settings July 26, 2026 16:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codspeed-hq

codspeed-hq Bot commented Jul 26, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 52.52%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 214 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory benchmark "devtool-eval", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 1.3 MB 3.1 MB -57.53%
Memory benchmark "asset-modules-resource", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 640.1 KB 1,205.6 KB -46.91%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing perf/compiler-hotpath-allocations (275301d) with main (8331267)

Open in CodSpeed

@alexander-akait
alexander-akait force-pushed the perf/compiler-hotpath-allocations branch from 049e57d to eb3036e Compare July 26, 2026 18:19
Copilot AI review requested due to automatic review settings July 26, 2026 18:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@alexander-akait
alexander-akait force-pushed the perf/compiler-hotpath-allocations branch from eb3036e to 5e77484 Compare July 26, 2026 19:11
Copilot AI review requested due to automatic review settings July 26, 2026 19:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

All changes are behavior-preserving and validated with isolated before/after
micro-benchmarks, profiled full-build A/B (GC-event count as a deterministic
allocation-churn proxy), full ConfigTestCases (8668, 548 snapshots),
TestCasesProduction, and yarn tsc.

Exports / reexport resolution (dominant cost on barrel-heavy graphs per CPU
profiling — ~21% fewer GC events on a reexport-heavy full build):
- ExportsInfo.findTarget: pass a shared empty visited-set (_findTarget only
  reads it) instead of a fresh Set per call.
- ExportsInfo.setTarget: copy exportName only when actually stored.
- isStarReexportBackToParent: allocate the visited set lazily.

ESM dependency templates (per import specifier / per reexport item):
- HarmonyImportSpecifierDependency: reuse the connection resolved in apply()
  instead of re-fetching it in _getCodeForIds; hoist the imported module's
  exports info out of the destructuring-replacement loop.
- HarmonyExportImportedSpecifierDependency: hoist getConnection and both
  getExportsInfo lookups out of the normal-reexport item loop; build
  ignoredExports in getStarReexports without the spread array.
- HarmonyImportDependency: drop a redundant template-literal re-wrap of
  userRequest.

Code generation:
- InitFragment.addToSource: flat index sort + numeric keyless keys.
- Template.getModulesArrayBounds: arithmetic module-id digit count, no string.
- HtmlGenerator: memoize module-by-identifier map per compilation (WeakMap).

Module concatenation (ConcatenatedModule):
- referencesByName single Map lookup; fold the build() dependency filter into
  the loop; build allIdentifiers Set without spreads.

Usage analysis (FlagDependencyUsagePlugin):
- Hoist the two stateless setUsedConditionally predicates; lazily allocate the
  usually-empty mangleableEscapeModules set.

Hashing (per module x runtime, every build):
- createModuleHashes: build the moduleHash cache key once per runtime.
- ChunkGraph graph-hash: hoist activeStateToString to module scope; compute
  strict only on cache miss.

Chunk splitting (SplitChunksPlugin):
- Remove the dead reusableChunks Set; hoist the loop-invariant
  getKey(usedChunks) out of the per-module loop.
@alexander-akait
alexander-akait force-pushed the perf/compiler-hotpath-allocations branch from 5e77484 to 66fe243 Compare July 26, 2026 19:43
Copilot AI review requested due to automatic review settings July 26, 2026 19:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Deno's node:fs.watch compatibility drops or delays change events, so the
WatchDetection cases intermittently time out waiting for the final rebuild.
Poll (only under Deno) for deterministic change pickup; Node and Bun keep
exercising native watching.
Copilot AI review requested due to automatic review settings July 26, 2026 20:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown
Contributor

Types Coverage

Coverage after merging perf/compiler-hotpath-allocations into main will be
99.32%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
bin
   webpack.js98.77%100%100%98.77%91
examples
   build-common.js100%100%100%100%
   buildAll.js100%100%100%100%
   examples.js100%100%100%100%
   template-common.js98.21%100%100%98.21%72
examples/custom-javascript-parser
   test.filter.js100%100%100%100%
examples/custom-javascript-parser/internals
   acorn-parse.js100%100%100%100%
   meriyah-parse.js100%100%100%100%
   oxc-parse.js100%100%100%100%
examples/markdown
   webpack.config.mjs100%100%100%100%
examples/module-federation
   test.filter.js100%100%100%100%
examples/reexport-components
   test.filter.js100%100%100%100%
examples/typescript
   test.filter.js100%100%100%100%
examples/typescript-non-erasable
   test.filter.js50%100%100%50%5
examples/virtual-modules
   test.filter.js100%100%100%100%
examples/wasm-bindgen-esm
   test.filter.js100%100%100%100%
examples/wasm-complex
   test.filter.js100%100%100%100%
examples/wasm-emscripten
   test.filter.js100%100%100%100%
examples/wasm-simple
   test.filter.js100%100%100%100%
examples/wasm-simple-source-phase
   test.filter.js100%100%100%100%
lib
   APIPlugin.js100%100%100%100%
   AsyncDependenciesBlock.js100%100%100%100%
   AutomaticPrefetchPlugin.js100%100%100%100%
   BannerPlugin.js100%100%100%100%
   Cache.js98.21%100%100%98.21%101
   CacheFacade.js100%100%100%100%
   Chunk.js99.72%100%100%99.72%39
   ChunkGraph.js100%100%100%100%
   ChunkGroup.js100%100%100%100%
   ChunkTemplate.js100%100%100%100%
   CircularModulesPlugin.js98.81%100%100%98.81%136
   CleanPlugin.js99.12%100%100%99.12%207, 227
   CodeGenerationResults.js100%100%100%100%
   CompatibilityPlugin.js100%100%100%100%
   Compilation.js98.42%100%100%98.42%1639, 1958, 1965, 1973, 1995, 1998, 2937, 3416–3417, 3449, 4149, 4179, 4232–4233, 4237, 4242, 4258–4259, 4273–4274, 4279–4280, 4760, 4786, 527, 532, 5594, 5626, 5643, 5659, 5675, 5690, 5715–5716, 5718, 6048, 6053, 6059, 6062, 6069, 6081, 6083, 6087, 6103, 6118, 6150, 6204, 6228, 6343, 778–779
   Compiler.js99.56%100%100%99.56%1147–1148, 1156
   ConcatenationScope.js98.65%100%100%98.65%195
   ConditionalInitFragment.js100%100%100%100%
   ConstPlugin.js100%100%100%100%
   ContextExclusionPlugin.js100%100%100%100%
   ContextModule.js99.88%100%100%99.88%1461
   ContextModuleFactory.js97.20%100%100%97.20%266, 435, 456, 461, 501, 512, 514, 518, 527–528
   ContextReplacementPlugin.js100%100%100%100%
   DefinePlugin.js99.08%100%100%99.08%1074, 176–177, 193, 212, 286
   DependenciesBlock.js100%100%100%100%
   Dependency.js98.51%100%100%98.51%479, 525
   DependencyTemplate.js100%100%100%100%
   DependencyTemplates.js100%100%100%100%
   DotenvPlugin.js98.41%100%100%98.41%378, 391–392
   DynamicEntryPlugin.js100%100%100%100%
   EntryOptionPlugin.js100%100%100%100%
   EntryPlugin.js100%100%100%100%
   Entrypoint.js100%100%100%100%
   EnvironmentPlugin.js97.14%100%100%97.14%49
   ErrorHelpers.js100%100%100%100%
   EvalDevToolModulePlugin.js100%100%100%100%
   EvalSourceMapDevToolPlugin.js100%100%100%100%
   ExportsInfo.js100%100%100%100%
   ExportsInfoApiPlugin.js100%100%100%100%
   ExternalModule.js98.65%100%100%98.65%1196, 1199, 514–518, 520, 666
   ExternalModuleFactoryPlugin.js100%100%100%100%
   ExternalsPlugin.js100%100%100%100%
   FileSystemInfo.js99.52%100%100%99.52%182, 2402–2403, 2406, 2417, 2428, 2439, 280, 3876, 3891, 3915
   FlagAllModulesAsUsedPlugin.js100%100%100%100%
   FlagDependencyExportsPlugin.js98.21%100%100%98.21%448, 457, 460, 464, 476
   FlagDependencyUsagePlugin.js100%100%100%100%
   FlagEntryExportAsUsedPlugin.js100%100%100%100%
   Generator.js100%100%100%100%
   HotModuleReplacementPlugin.js100%100%100%100%
   HotUpdateChunk.js100%100%100%100%
   IgnorePlugin.js100%100%100%100%
   IgnoreWarningsPlugin.js100%100%100%100%
   InitFragment.js100%100%100%100%
   JavascriptMetaInfoPlugin.js100%100%100%100%
   LazyBarrel.js100%100%100%100%
   LibraryTemplatePlugin.js100%100%100%100%
   LoaderOptionsPlugin.js100%100%100%100%
   LoaderTargetPlugin.js100%100%100%100%
   MainTemplate.js100%100%100%100%
   ManifestPlugin.js100%100%100%100%
   Module.js98.50%100%100%98.50%1288, 1293, 1353, 1367, 1429, 1438
   ModuleFactory.js100%100%100%100%
   ModuleFilenameHelpers.js98.85%100%100%98.85%106, 108
   ModuleGraph.js99.73%100%100%99.73%1005
   ModuleGraphConnection.js100%100%100%100%
   ModuleInfoHeaderPlugin.js100%100%100%100%
   ModuleNotFoundError.js100%100%100%100%
   ModuleProfile.js100%100%100%100%
   ModuleSourceTypeConstants.js100%100%100%100%
   ModuleTemplate.js100%100%100%100%
   ModuleTypeConstants.js100%100%100%100%
   MultiCompiler.js99.70%100%100%99.70%663
   MultiStats.js100%100%100%100%
   MultiWatching.js100%100%100%100%
   NoEmitOnErrorsPlugin.js100%100%100%100%
   NodeStuffPlugin.js100%100%100%100%
   NormalModule.js97.98%100%100%97.98%1014, 1031, 1279, 1313, 1329, 1776, 2073, 2078–2088, 34, 994, 997
   NormalModuleFactory.js98.72%100%100%98.72%1117, 1385, 1396, 1406, 1457–1459, 1466, 520, 532
   NormalModuleReplacementPlugin.js100%100%100%100%
   NullFactory.js100%100%100%100%
   OptimizationStages.js100%100%100%100%
   OptionsApply.js100%100%100%100%
   Parser.js100%100%100%100%
   PlatformPlugin.js100%100%100%100%
   PrefetchPlugin.js100%100%100%100%
   ProgressPlugin.js99.80%100%100%99.80%691
   ProvidePlugin.js100%100%100%100%
   RawModule.js100%100%100%100%
   RecordIdsPlugin.js100%100%100%100%
   RequestShortener.js100%100%100%100%
   ResolverFactory.js100%100%100%100%
   RuntimeGlobals.js100%100%100%100%
   RuntimeModule.js100%100%100%100%
   RuntimePlugin.js100%100%100%100%
   RuntimeTemplate.js100%100%100%100%
   SelfModuleFactory.js100%100%100%100%
   SingleEntryPlugin.js100%100%100%100%
   SourceMapDevToolModuleOptionsPlugin.js100%100%100%100%
   SourceMapDevToolPlugin.js98.62%100%100%98.62%220, 224, 226, 419, 430, 889
   Stats.js100%100%100%100%
   Template.js100%100%100%100%
   TemplatedPathPlugin.js99.43%100%100%99.43%308–309
   UseStrictPlugin.js100%100%100%100%
   WarnCaseSensitiveModulesPlugin.js100%100%100%100%
   WarnDeprecatedOptionPlugin.js100%100%100%100%
   WarnNoModeSetPlugin.js100%100%100%100%
   WatchIgnorePlugin.js100%100%100%100%
   Watching.js100%100%100%100%
   WebpackError.js100%100%100%100%
   WebpackIsIncludedPlugin.js100%100%100%100%
   WebpackOptionsApply.js100%100%100%100%
   WebpackOptionsDefaulter.js100%100%100%100%
   buildChunkGraph.js99.87%100%100%99.87%371
   cli.js98.63%100%100%98.63%10, 119, 549, 581, 631, 905
   index.js99.72%100%100%99.72%184
   validateSchema.js94.67%100%100%94.67%100, 87, 89, 98
   webpack.js97.10%100%100%97.10%10, 263, 285, 287
lib/asset
   AssetBytesGenerator.js100%100%100%100%
   AssetBytesParser.js100%100%100%100%
   AssetGenerator.js100%100%100%100%
   AssetModule.js100%100%100%100%
   AssetModulesPlugin.js97.95%100%100%97.95%295, 319, 322, 42, 452, 47
   AssetParser.js100%100%100%100%
   AssetSourceGenerator.js100%100%100%100%
   AssetSourceParser.js100%100%100%100%
   RawDataUrlModule.js100%100%100%100%
   WebManifestGenerator.js100%100%100%100%
   WebManifestParser.js100%100%100%100%
lib/async-modules
   AsyncModuleHelpers.js100%100%100%100%
   AwaitDependenciesInitFragment.js100%100%100%100%
   InferAsyncModulesPlugin.js100%100%100%100%
   isGeneratorLowered.js100%100%100%100%
lib/bun
   BunTargetPlugin.js100%100%100%100%
lib/cache
   AddBuildDependenciesPlugin.js100%100%100%100%
   AddManagedPathsPlugin.js100%100%100%100%
   IdleFileCachePlugin.js97.92%100%100%97.92%75, 87, 95
   MemoryCachePlugin.js95.83%100%100%95.83%33
   MemoryWithGcCachePlugin.js93.15%100%100%93.15%107, 114–115, 123, 90
   PackFileCacheStrategy.js96.41%100%100%96.41%1257, 1357, 1361, 1423, 628, 647, 657–659, 661, 677–678, 683, 686, 688, 693, 698, 723, 729, 763, 769, 775, 780, 791, 800, 805–806, 808, 825, 831–832, 834
   ResolverCachePlugin.js100%100%100%100%
   getLazyHashedEtag.js100%100%100%100%
   mergeEtags.js100%100%100%100%
lib/config
   browserslistTargetHandler.js100%100%100%100%
   defaults.js99.37%100%100%99.37%1620–1622, 1630,

@alexander-akait
alexander-akait merged commit fbcbe3e into main Jul 26, 2026
62 checks passed
@alexander-akait
alexander-akait deleted the perf/compiler-hotpath-allocations branch July 26, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants