Skip to content

feat: support cross-module pure detection in inner graph#20907

Open
hai-x wants to merge 1 commit into
mainfrom
refactor-innergraph
Open

feat: support cross-module pure detection in inner graph#20907
hai-x wants to merge 1 commit into
mainfrom
refactor-innergraph

Conversation

@hai-x
Copy link
Copy Markdown
Member

@hai-x hai-x commented May 4, 2026

Summary

Refactors the InnerGraph tree-shaking utility so purity can be tracked across module boundaries, not just
within a single module.

What kind of change does this PR introduce?

TL;DR

A /*#__NO_SIDE_EFFECTS__*/ annotation in one module is now honored by call sites in other modules — not
just within the file it was declared in.
Example

// pure.js
/*#__NO_SIDE_EFFECTS__*/
export function pureFn(x) { return x; }

// index.js
import { pureFn } from "./pure";

const r = pureFn(1);   // result never read

Before this PR, pureFn shows up in usedExports because the /*#__NO_SIDE_EFFECTS__*/ hint stayed inside
pure.js and never reached the importer, so the call site pureFn(1) was treated as a usage with sideEffects.
After this PR, pureFn export can be tree-shaken.

How the optimization works:

  1. Producer records purity locally. While parsing pure.js, the parser sees the
    /*#__NO_SIDE_EFFECTS__*/ and writes the name into
    module.buildInfo.pureFunctions. At this point the purity is just a per-module fact.

  2. Purity is lifted onto the export descriptor. When HarmonyExportSpecifierDependency / HarmonyExportExpressionDependency build their ExportsSpec, they consult
    buildInfo.pureFunctions and emit { name: "pureFn", isPure: true }. This is the
    only channel that crosses the module boundary.

  3. FlagDependencyExportsPlugin propagates isPure to ExportInfo and the
    new isPure flag is copied onto the matching ExportInfo.

  4. Importer tags the local binding with a deferred pure predicate. When index.js is parsed, the inner graph
    creates a TopLevelSymbol for the imported pureFn and its pure field is a function for purpose of deferring instead of definite true. The deferral matters because the importing module may not yet be parsed.

  5. Per-compilation state. Inner-graph state is now scoped to the Compilation
    (getInnerGraph(compilation)) and keyed by Module, which is what lets step 4 reach into another module's
    ExportsInfo from inside the importer's graph.

  6. Inference resolves the call. When inferDependencyUsage walks the importer's graph, it reaches the
    pureFn(1) call, asks the symbol isPure(compilation, module), gets true, so propagate pure-symbol usage through the inner graph.

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

No

If relevant, what needs to be documented once your changes are merged or what have you already documented?

No

Use of AI

Partial

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 4, 2026

⚠️ No Changeset found

Latest commit: b53d0c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hai-x hai-x force-pushed the refactor-innergraph branch from 6e9739c to d6db533 Compare May 4, 2026 06:26
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

This PR is packaged and the instant preview is available (b53d0c6).

Install it locally:

  • npm
npm i -D webpack@https://pkg.pr.new/webpack@b53d0c6
  • yarn
yarn add -D webpack@https://pkg.pr.new/webpack@b53d0c6
  • pnpm
pnpm add -D webpack@https://pkg.pr.new/webpack@b53d0c6

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 17.85714% with 299 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.35%. Comparing base (3032402) to head (b53d0c6).

Files with missing lines Patch % Lines
lib/optimize/InnerGraph.js 18.45% 137 Missing ⚠️
lib/optimize/InnerGraphPlugin.js 16.10% 99 Missing ⚠️
lib/optimize/SideEffectsFlagPlugin.js 23.33% 23 Missing ⚠️
.../dependencies/HarmonyExportExpressionDependency.js 9.09% 10 Missing ⚠️
...ependencies/HarmonyImportDependencyParserPlugin.js 11.11% 8 Missing ⚠️
lib/FlagDependencyExportsPlugin.js 0.00% 7 Missing ⚠️
...b/dependencies/HarmonyExportSpecifierDependency.js 0.00% 4 Missing ⚠️
lib/JavascriptMetaInfoPlugin.js 40.00% 3 Missing ⚠️
lib/ExportsInfo.js 50.00% 2 Missing ⚠️
...ependencies/HarmonyExportDependencyParserPlugin.js 33.33% 2 Missing ⚠️
... and 3 more

❌ Your patch check has failed because the patch coverage (17.85%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20907      +/-   ##
==========================================
- Coverage   36.42%   36.35%   -0.08%     
==========================================
  Files         423      423              
  Lines       48221    48337     +116     
  Branches    13222    13263      +41     
==========================================
+ Hits        17565    17572       +7     
- Misses      30656    30765     +109     
Flag Coverage Δ
unit 36.35% <17.85%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 4, 2026

Merging this PR will degrade performance by 24.16%

⚡ 4 improved benchmarks
❌ 5 regressed benchmarks
✅ 135 untouched benchmarks
⏩ 72 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory benchmark "asset-modules-resource", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 209.6 KB 346.2 KB -39.44%
Memory benchmark "json-modules", scenario '{"name":"mode-development","mode":"development"}' 573.6 KB 441.6 KB +29.9%
Memory benchmark "many-modules-esm", scenario '{"name":"mode-development","mode":"development"}' 1,356 KB 841.3 KB +61.18%
Memory benchmark "wasm-modules-sync", scenario '{"name":"mode-production","mode":"production"}' 7.5 MB 5.9 MB +27.45%
Memory benchmark "context-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 256.8 KB 472.6 KB -45.66%
Memory benchmark "future-defaults", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 143.7 KB 325.6 KB -55.86%
Memory benchmark "devtool-eval", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 920.5 KB 409.2 KB ×2.2
Memory benchmark "lodash", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 132.5 KB 320.2 KB -58.61%
Memory benchmark "cache-filesystem", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 193.6 KB 842 KB -77%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing refactor-innergraph (b53d0c6) with main (3032402)

Open in CodSpeed

Footnotes

  1. 72 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@hai-x hai-x force-pushed the refactor-innergraph branch 4 times, most recently from 9238fbc to 8c90e76 Compare May 6, 2026 18:38
@hai-x hai-x changed the title refactor: inner graph per compilation refactor: crossing module pure detection in inner graph May 11, 2026
@hai-x hai-x force-pushed the refactor-innergraph branch 3 times, most recently from e7c4f69 to bb09288 Compare May 16, 2026 19:12
Comment thread test/configCases/inner-graph/cross-module-pure-namespace-import/index.js Dismissed
Comment thread test/configCases/inner-graph/cross-module-pure-namespace-import/index.js Dismissed
Comment thread test/configCases/inner-graph/cross-module-pure-namespace-import/index.js Dismissed
Comment thread test/configCases/inner-graph/cross-module-pure-namespace-import/index.js Dismissed
Comment thread test/configCases/inner-graph/cross-module-pure-namespace-import/index.js Dismissed
Comment thread test/configCases/inner-graph/cross-module-pure-namespace-import/index.js Dismissed
Comment thread test/configCases/inner-graph/cross-module-pure-namespace-import/index.js Dismissed
Comment thread test/configCases/inner-graph/cross-module-pure-normal/index.js Dismissed
Comment thread test/configCases/inner-graph/cross-module-pure-normal/index.js Dismissed
Comment thread test/configCases/inner-graph/cross-module-pure-normal/index.js Dismissed
@hai-x hai-x changed the title refactor: crossing module pure detection in inner graph feat: support cross-module pure detection in inner graph May 16, 2026
@hai-x hai-x marked this pull request as ready for review May 16, 2026 19:39
@hai-x hai-x force-pushed the refactor-innergraph branch from bb09288 to 6cca22d Compare May 16, 2026 19:49
@hai-x hai-x force-pushed the refactor-innergraph branch from 6cca22d to b53d0c6 Compare May 16, 2026 19:55
@github-actions
Copy link
Copy Markdown
Contributor

Types Coverage

Coverage after merging refactor-innergraph into main will be
98.95%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
bin
   webpack.js98.77%100%100%98.77%91
examples
   build-common.js100%100%100%100%
   buildAll.js100%100%100%100%
   examples.js100%100%100%100%
   template-common.js98.21%100%100%98.21%72
examples/custom-javascript-parser
   test.filter.js100%100%100%100%
examples/custom-javascript-parser/internals
   acorn-parse.js100%100%100%100%
   meriyah-parse.js100%100%100%100%
   oxc-parse.js91.30%100%100%91.30%140, 142–143, 145, 147, 153–154, 161, 168, 90
examples/markdown
   webpack.config.mjs100%100%100%100%
examples/typescript
   test.filter.js50%100%100%50%5
examples/virtual-modules
   test.filter.js100%100%100%100%
examples/wasm-bindgen-esm
   test.filter.js100%100%100%100%
examples/wasm-complex
   test.filter.js100%100%100%100%
examples/wasm-simple
   test.filter.js100%100%100%100%
examples/wasm-simple-source-phase
   test.filter.js100%100%100%100%
lib
   APIPlugin.js100%100%100%100%
   AsyncDependenciesBlock.js100%100%100%100%
   AutomaticPrefetchPlugin.js100%100%100%100%
   BannerPlugin.js100%100%100%100%
   Cache.js98.21%100%100%98.21%101
   CacheFacade.js100%100%100%100%
   Chunk.js99.72%100%100%99.72%37
   ChunkGraph.js100%100%100%100%
   ChunkGroup.js100%100%100%100%
   ChunkTemplate.js100%100%100%100%
   CleanPlugin.js98.72%100%100%98.72%206, 226, 382
   CodeGenerationResults.js100%100%100%100%
   CompatibilityPlugin.js100%100%100%100%
   Compilation.js98.55%100%100%98.55%1554, 1850, 1857, 1865, 1887, 2783, 3208, 3870, 3899, 3952–3953, 3957, 3962, 3978–3979, 3993–3994, 3999–4000, 4477, 4503, 493, 498, 5211, 5292, 5307, 5332–5333, 5335, 5659, 5664, 5670, 5673, 5685, 5687, 5691, 5707, 5722, 5754, 5808, 5832, 5946, 712–713
   Compiler.js99.55%100%100%99.55%1116–1117, 1125
   ConcatenationScope.js98.59%100%100%98.59%189
   ConditionalInitFragment.js100%100%100%100%
   ConstPlugin.js100%100%100%100%
   ContextExclusionPlugin.js100%100%100%100%
   ContextModule.js100%100%100%100%
   ContextModuleFactory.js97.75%100%100%97.75%258, 393, 418, 443, 447, 458
   ContextReplacementPlugin.js100%100%100%100%
   DefinePlugin.js98.92%100%100%98.92%158–159, 175, 194, 268
   DependenciesBlock.js100%100%100%100%
   Dependency.js98.20%100%100%98.20%381, 427
   DependencyTemplate.js100%100%100%100%
   DependencyTemplates.js100%100%100%100%
   DotenvPlugin.js97.88%100%100%97.88%237, 378, 391–392
   DynamicEntryPlugin.js100%100%100%100%
   EntryOptionPlugin.js100%100%100%100%
   EntryPlugin.js100%100%100%100%
   Entrypoint.js100%100%100%100%
   EnvironmentPlugin.js97.14%100%100%97.14%49
   ErrorHelpers.js100%100%100%100%
   EvalDevToolModulePlugin.js100%100%100%100%
   EvalSourceMapDevToolPlugin.js100%100%100%100%
   ExportsInfo.js100%100%100%100%
   ExportsInfoApiPlugin.js100%100%100%100%
   ExternalModule.js98.96%100%100%98.96%424–428, 576
   ExternalModuleFactoryPlugin.js100%100%100%100%
   ExternalsPlugin.js100%100%100%100%
   FileSystemInfo.js99.50%100%100%99.50%182, 2252–2253, 2256, 2267, 2278, 2289, 278, 3694, 3709, 3733
   FlagAllModulesAsUsedPlugin.js100%100%100%100%
   FlagDependencyExportsPlugin.js98.78%100%100%98.78%409, 411, 415
   FlagDependencyUsagePlugin.js100%100%100%100%
   FlagEntryExportAsUsedPlugin.js100%100%100%100%
   Generator.js100%100%100%100%
   HotModuleReplacementPlugin.js100%100%100%100%
   HotUpdateChunk.js100%100%100%100%
   IgnorePlugin.js100%100%100%100%
   IgnoreWarningsPlugin.js100%100%100%100%
   InitFragment.js100%100%100%100%
   JavascriptMetaInfoPlugin.js100%100%100%100%
   LibraryTemplatePlugin.js100%100%100%100%
   LoaderOptionsPlugin.js100%100%100%100%
   LoaderTargetPlugin.js100%100%100%100%
   MainTemplate.js100%100%100%100%
   ManifestPlugin.js100%100%100%100%
   Module.js98.50%100%100%98.50%1305, 1310, 1371, 1385, 1447, 1456
   ModuleFactory.js100%100%100%100%
   ModuleFilenameHelpers.js98.85%100%100%98.85%106, 108
   ModuleGraph.js99.73%100%100%99.73%1004
   ModuleGraphConnection.js100%100%100%100%
   ModuleInfoHeaderPlugin.js100%100%100%100%
   ModuleProfile.js100%100%100%100%
   ModuleSourceTypeConstants.js100%100%100%100%
   ModuleTemplate.js100%100%100%100%
   ModuleTypeConstants.js100%100%100%100%
   MultiCompiler.js99.69%100%100%99.69%645
   MultiStats.js100%100%100%100%
   MultiWatching.js100%100%100%100%
   NoEmitOnErrorsPlugin.js100%100%100%100%
   NodeStuffPlugin.js100%100%100%100%
   NormalModule.js97.78%100%100%97.78%1020, 1036, 1123, 1774, 1779–1789, 708, 711, 728, 745, 986
   NormalModuleFactory.js99.47%100%100%99.47%1074, 1383, 473, 485
   NormalModuleReplacementPlugin.js100%100%100%100%
   NullFactory.js100%100%100%100%
   OptimizationStages.js100%100%100%100%
   OptionsApply.js100%100%100%100%
   Parser.js100%100%100%100%
   PlatformPlugin.js100%100%100%100%
   PrefetchPlugin.js100%100%100%100%
   ProgressPlugin.js98.85%100%100%98.85%519–520, 525, 527, 591
   ProvidePlugin.js100%100%100%100%
   RawModule.js100%100%100%100%
   RecordIdsPlugin.js100%100%100%100%
   RequestShortener.js100%100%100%100%
   ResolverFactory.js100%100%100%100%
   RuntimeGlobals.js100%100%100%100%
   RuntimeModule.js100%100%100%100%
   RuntimePlugin.js100%100%100%100%
   RuntimeTemplate.js100%100%100%100%
   SelfModuleFactory.js100%100%100%100%
   SingleEntryPlugin.js100%100%100%100%
   SourceMapDevToolModuleOptionsPlugin.js100%100%100%100%
   SourceMapDevToolPlugin.js99.16%100%100%99.16%267–268, 610
   Stats.js100%100%100%100%
   Template.js100%100%100%100%
   TemplatedPathPlugin.js98.86%100%100%98.86%134–135
   UseStrictPlugin.js100%100%100%100%
   WarnCaseSensitiveModulesPlugin.js100%100%100%100%
   WarnDeprecatedOptionPlugin.js100%100%100%100%
   WarnNoModeSetPlugin.js100%100%100%100%
   WatchIgnorePlugin.js100%100%100%100%
   Watching.js100%100%100%100%
   WebpackError.js100%100%100%100%
   WebpackIsIncludedPlugin.js100%100%100%100%
   WebpackOptionsApply.js100%100%100%100%
   WebpackOptionsDefaulter.js100%100%100%100%
   buildChunkGraph.js99.87%100%100%99.87%325
   cli.js98.71%100%100%98.71%117, 469, 501, 543, 813
   index.js100%100%100%100%
   validateSchema.js94.67%100%100%94.67%100, 87, 89, 98
   webpack.js97.22%100%100%97.22%196, 218, 220
lib/asset
   AssetBytesGenerator.js100%100%100%100%
   AssetBytesParser.js100%100%100%100%
   AssetGenerator.js100%100%100%100%
   AssetModulesPlugin.js97.77%100%100%97.77%285, 309, 312, 364, 40
   AssetParser.js100%100%100%100%
   AssetSourceGenerator.js100%100%100%100%
   AssetSourceParser.js100%100%100%100%
   RawDataUrlModule.js100%100%100%100%
lib/async-modules
   AsyncModuleHelpers.js100%100%100%100%
   AwaitDependenciesInitFragment.js100%100%100%100%
   InferAsyncModulesPlugin.js100%100%100%100%
lib/cache
   AddBuildDependenciesPlugin.js100%100%100%100%
   AddManagedPathsPlugin.js100%100%100%100%
   IdleFileCachePlugin.js97.92%100%100%97.92%71, 83, 91
   MemoryCachePlugin.js95.83%100%100%95.83%33
   MemoryWithGcCachePlugin.js93.15%100%100%93.15%106, 113–114, 122, 89
   PackFileCacheStrategy.js96.40%100%100%96.40%1250, 1350, 1354, 1416, 628, 647, 657–659, 661, 677–678, 683, 686, 688, 693, 698, 722, 728, 762, 768, 774, 779, 790, 799, 804–805, 807, 824, 830–831, 833
   ResolverCachePlugin.js100%100%100%100%
   getLazyHashedEtag.js100%100%100%100%
   mergeEtags.js100%100%100%100%
lib/config
   browserslistTargetHandler.js100%100%100%100%
   defaults.js99.15%100%100%99.15%1342–1344, 1352, 271, 274, 279, 283, 472
   normalization.js99%100%100%99%191–192, 258, 273
   target.js100%100%100%100%
lib/container
   ContainerEntryDependency.js100%100%100%100%
   ContainerEntryModule.js100%100%100%100%
   ContainerEntryModuleFactory.js100%100%100%100%
   ContainerExposedDependency.js100%100%100%100%
   ContainerPlugin.js100%100%100%100%
   ContainerReferencePlugin.js100%100%100%100%
   FallbackDependency.js100%100%100%100%
   FallbackItemDependency.js100%100%100%100%
   FallbackModule.js100%100%100%100%
   FallbackModuleFactory.js100%100%100%100%
   HoistContainerReferencesPlugin.js100%100%100%100%
   ModuleFederationPlugin.js100%100%100%100%
   RemoteModule.js100%100%100%100%
   RemoteRuntimeModule.js100%100%100%100%
   

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant