feat: optimize regex generation using character ranges #20003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
requested changes
Oct 10, 2025
| // optimize by using character ranges: e.g., [1-4a] instead of [1234a] | ||
| if (countOfSingleCharItems === itemsArr.length) { | ||
| return `[${quoteMeta(itemsArr.sort().join(""))}]`; | ||
| const sorted = itemsArr.sort(); |
There was a problem hiding this comment.
Thanks for contributing! Could you abstract this logic and add tests to your pr?
|
@CodewithEvilxd nice work. Could you rebase and add tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes regex generation in compileBooleanMatcher by using character ranges for better performance.
Changes:
[1-4a]instead of[1234a]What kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?