feat: add cache.storeFilter for filtering cached assets #19577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cseas
commented
Jun 3, 2025
| export interface MemoryCacheOptions { | ||
| /** | ||
| * Additionally cache computation of modules that are unchanged and reference only unchanged modules. | ||
| * Additionally cache computation of modules that are unchanged and reference only unchanged modules in memory. |
There was a problem hiding this comment.
I didn't change this line. This was added automatically by yarn run fix:special
| /** | ||
| * A function to filter which cache entries should be stored. Return false to skip storing a cache entry. | ||
| */ | ||
| storeFilter?: (identifier: string, data: any) => boolean; |
There was a problem hiding this comment.
Function signature is similar to the one suggested by @alexander-akait here but I'm not sure if there are any use-cases for filtering on data.
Need input from the maintainers here. If it isn't required, I'll go ahead and remove the data parameter.
@alexander-akait I've added the storeFilter property to MemoryCachePlugin as well. Also added unit tests for both IdleFileCachePlugin and MemoryCachePlugin. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19359
What kind of change does this PR introduce?
Add a new config option
cache.storeFileswhich gives the users an option to configure filtering for which assets should be excluded from cache.Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
cache.type: 'memory'not allowing additional configuration.