fix:that the external modules load without reload when lazy-compilation #19477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!hooks) { | ||
| hooks = { | ||
| createScript: new SyncWaterfallHook(["source", "chunk"]) | ||
| createScript: new SyncWaterfallHook(["code", "chunk"]) |
There was a problem hiding this comment.
Please avoid unnecessary changes which is not related to fixes
lib/hmr/LazyCompilationPlugin.js
Outdated
| } | ||
| return false; | ||
| }) | ||
| : false; |
There was a problem hiding this comment.
Bad idea, we should register runtime inside ExternalModule
| makeSerializable( | ||
| ExternalModuleInitFragment, | ||
| "webpack/lib/dependencies/ExternalModuleInitFragment" | ||
| ); |
CodSpeed Performance ReportMerging #19477 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #19134
Fixed issue with external dependencies not loading properly on first visit when lazy compilation is enabled
Added logic to ensure external dependencies are properly initialized before lazy-loaded chunks that depend on them
Enhanced the LazyCompilationProxyModule to detect and handle external dependencies
Added new runtime helper to ensure external dependencies are loaded in the correct order