This repository was archived by the owner on Dec 17, 2025. It is now read-only.
feature: stringify loader object - fixes #95#206
Open
peter-spireng wants to merge 1 commit intowebpack:masterfrom
Open
feature: stringify loader object - fixes #95#206peter-spireng wants to merge 1 commit intowebpack:masterfrom
peter-spireng wants to merge 1 commit intowebpack:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #206 +/- ##
==========================================
+ Coverage 76.66% 77.17% +0.50%
==========================================
Files 10 11 +1
Lines 360 368 +8
Branches 112 114 +2
==========================================
+ Hits 276 284 +8
Misses 73 73
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
I don't think we need it here, you can implement this on loader side
Contributor
Author
|
Issue #95 is still open with "Help wanted" label, so I thought it is still valid feature request ... |
Member
|
We should avoid adding new methods here, if we really need it, we should implement it on webpack side (but I don't think we really need it). We want to deprecated it on the next major release. And yes, we need to close issues... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At first moment we need agree on API and stringfy result. So, can you please review tests and if they are right, I can add real implementation.