Update samples to work with TypeScript strict mode (part 1)#278
Update samples to work with TypeScript strict mode (part 1)#278kainino0x merged 4 commits intowebgpu:mainfrom
Conversation
kainino0x
force-pushed
the
chore/strict_true
branch
from
cda5614 to
41b32fe
Compare
|
Looking good so far, hopefully the suggestions will make updating the rest of the samples a bit easier - ping me when you need another review! |
|
And do be sure to pull the branch before you continue, because I committed suggestions to it. |
|
Thank you for the review! I just did a git pull for your changes. Once I've corrected all the examples, I'll request a re-review from you! |
|
Hi @nash1111, will you still be able to complete this PR? If not, someone else can pick it up (eventually)! |
|
I am capable of handling it, but given the volume, I'm considering splitting it into two PRs. The first PR will modify only the files that have been completed so far with strict: false, and the second will edit the remaining files to make the entire project strict: true. I believe that smaller PRs are preferable, so I'll be aiming for that. This PR is the first one. |
kainino0x
changed the title
2 participants
Like this, I want to add types to all samples to enhance safety. If there are no issues, I would like to proceed with adding them to all.