Fix response parsing for MultipleItems requests#97
Open
Saltiola7 wants to merge 1 commit intowebflow:mainfrom
Open
Fix response parsing for MultipleItems requests#97Saltiola7 wants to merge 1 commit intowebflow:mainfrom
Saltiola7 wants to merge 1 commit intowebflow:mainfrom
Conversation
Open
Collaborator
|
Hi @Saltiola7 - we'll take a look at this. Which version of the lib are you using? |
Author
|
2.0.0b1 in the pyproject.toml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description
When using the
MultipleItemsclass to create multiple items at once, the SDK incorrectly tried to parse the API response as aCollectionItemobject. However, when creating multiple items, the API returns a response with anitemsfield containing a list of items, which should be parsed as aCollectionItemListobject.This caused a validation error:
Solution
I modified the
create_itemmethod inclient.pyto check if the request is aMultipleItemsobject and, if so, parse the response as aCollectionItemListinstead of aCollectionItem. This correctly handles the different response formats based on the request type.Changes:
typing.Union[CollectionItem, CollectionItemList]Testing
I've tested this change by creating multiple items at once using the
MultipleItemsclass, and the SDK now correctly parses the response without validation errors.