Update the docs about submodules and action ordering.#92
Open
KubaO wants to merge 2 commits intowebfactory:masterfrom
Open
Update the docs about submodules and action ordering.#92KubaO wants to merge 2 commits intowebfactory:masterfrom
KubaO wants to merge 2 commits intowebfactory:masterfrom
Conversation
mpdude
reviewed
Oct 19, 2022
Comment on lines
+35
to
+36
| # This action has to precede ssh-agent, since it undoes its effects | ||
| - uses: actions/checkout@v2 |
Member
There was a problem hiding this comment.
Maybe that is fixed in actions/checkout#833, unless submodules are used?
mpdude
reviewed
Oct 19, 2022
Comment on lines
+110
to
+112
| The `ssh-agent` step *cannot* precede the `checkout` step, though. The `checkout` action undoes the effects of `ssh-agent`. This will cause errors like: | ||
|
|
||
| ssh: Could not resolve hostname key-<hex-key-id>.github.com: Name or service not known |
Member
There was a problem hiding this comment.
Once actions/checkout#833 is merged, that should not happen unless submodules are turned on?
There was a problem hiding this comment.
I think this is linked to #148 which is caused by the checkout action setting up a temp HOME directory which breaks the ssh configuration.
On linux, submodule support is OK with ssh-agent preceding the checkout action.
Member
|
I prefer not to merge this unless I fully understand the problem and we have discussed possible alternative (?) solutions. I have opened actions/checkout#973 to co-ordinate with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #91