Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR contains various updates to Vue component files, TypeScript interfaces, and template props to improve consistency and type safety as well as to remove deprecated or unused props. Key changes include:
- Updating the FieldLabel component’s prop interface for a more concise optional definition.
- Refining the type handling in the VSFButtonField component.
- Removing the :codeBlockSettings prop in several documentation example components and updating the DocsPage usage.
- Adding a Props interface for the open prop in multiple documentation examples for consistency.
- Introducing defineOptions in ExampleContainer.vue to disable attribute inheritance.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/plugin/components/shared/FieldLabel.vue | Simplified TS interface for the required property. |
| src/plugin/components/fields/VSFButtonField/VSFButtonField.vue | Enhanced type handling in getId and isActive functions. |
| src/documentation/sections/ExampleSection.vue | Removed :codeBlockSettings prop from ExampleContainer usage. |
| src/documentation/components/examples/* | Added a Props interface to define an optional open prop consistently. |
| src/documentation/components/ExampleContainer.vue | Added defineOptions to disable inherited attributes. |
| src/App.vue | Removed passing codeBlockOptions to DocsPage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.