Skip to content

Reject extra rules in a font-feature-values fixture - #64192

Open
domenic wants to merge 1 commit into
masterfrom
codex/fix-font-feature-values-extra-rule-fixture
Open

domenic wants to merge 1 commit into
masterfrom
codex/fix-font-feature-values-extra-rule-fixture

Conversation

@domenic

@domenic domenic commented Oct 25, 2026

Copy link
Copy Markdown
Member

The closing brace after @blah ends the outer @font-feature-values rule. The remaining @styleset rule and closing brace are top-level trailing input, so insertRule() must throw SyntaxError: parsing a single rule requires EOF after that rule. Mark this fixture invalid instead of expecting recovery inside a single @font-feature-values rule.

https://drafts.csswg.org/css-syntax-3/#parse-rule
https://drafts.csswg.org/cssom/#dom-cssstylesheet-insertrule

The closing brace after `@blah` ends the outer `@font-feature-values` rule. The remaining `@styleset` rule and closing brace are top-level trailing input, so `insertRule()` must throw `SyntaxError`: parsing a single rule requires EOF after that rule. Mark this fixture invalid instead of expecting recovery inside a single `@font-feature-values` rule.

https://drafts.csswg.org/css-syntax-3/#parse-rule
https://drafts.csswg.org/cssom/#dom-cssstylesheet-insertrule

Co-authored-by: codex <codex@openai.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants