Repository navigation
Conversation
…-collapsing
LineLayout::isSelfCollapsingContent() looks for the block level box on a line so it can ask whether that
box is self-collapsing. It iterates the line's display boxes with
for (auto index = line.firstBoxIndex(); index < line.lastBoxIndex(); ++index)
but lastBoxIndex() is firstBoxIndex() + boxCount() - 1, an inclusive index, so the last box on the line is
never examined. A block level box on a line is typically the last box on it, in which case the look-up
returns nullptr and the "renderBox && !renderBox->isSelfCollapsingBlock()" test is skipped altogether.
WebKit-Bug: https://bugs.webkit.org/show_bug.cgi?id=321198
WebKit-Canonical-Link: https://commits.webkit.org/318782@main
wpt-pr-bot
approved these changes
Oct 25, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the WebKit project.
annevk
enabled auto-merge (rebase)
October 25, 2026 08:55
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebKit export from bug: [block-in-inline] A block whose content is a table is treated as self-collapsing
[block-in-inline] A block whose content is a table is treated as self-collapsing LineLayout::isSelfCollapsingContent() looks for the block level box on a line so it can ask whether that box is self-collapsing. It iterates the line's display boxes with for (auto index = line.firstBoxIndex(); index < line.lastBoxIndex(); ++index) but lastBoxIndex() is firstBoxIndex() + boxCount() - 1, an inclusive index, so the last box on the line is never examined. A block level box on a line is typically the last box on it, in which case the look-up returns nullptr and the "renderBox && !renderBox->isSelfCollapsingBlock()" test is skipped altogether. WebKit-Bug: https://bugs.webkit.org/show_bug.cgi?id=321198 WebKit-Canonical-Link: https://commits.webkit.org/318782@main