Repository navigation
Conversation
…-of-flow children by the position of its line An out-of-flow box whose containing block is an inline box is laid out against the nearest non-anonymous block, so the distance from that block to the inline's own first fragment has to be added back. RenderInline::offsetForInFlowPositionedInline is what returns it, taking the inline box's logicalTop, and all four of its callers ask for it only when the inline is in-flow positioned. An inline is the containing block for other reasons too, a filter among them, and in those cases the offset was dropped. An anonymous block around the inline hid this. The wrapper is a RenderBox, so its own topLeftLocationOffset carries the distance up the box chain in offsetFromContainer, and the inline sits at the top of the wrapper's first line, which leaves the half-leading at most to add. With a block level box on a line there is no wrapper: the inline's parent is the container itself, a RenderInline contributes no location offset of its own, and the whole distance down to the line is left to offsetForInFlowPositionedInline. Ask whether the inline is the containing block rather than whether it is in-flow positioned. For a RenderInline canContainAbsolutelyPositionedObjects covers the fixed position case as well, since the willChange term of each only applies to a RenderBlock, leaving mayContainOutOfFlowPositionedObjects and a non-static position. WebKit-Bug: https://bugs.webkit.org/show_bug.cgi?id=321397 WebKit-Canonical-Link: https://commits.webkit.org/318897@main
wpt-pr-bot
approved these changes
Oct 25, 2026
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the WebKit project.
annevk
enabled auto-merge (rebase)
October 25, 2026 08:55
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebKit export from bug: [block-in-inline] Only a relatively positioned inline offsets its out-of-flow children by the position of its line