Repository navigation
Conversation
… side of the list item
<style>
::marker { direction: rtl }
</style>
<ol><li>text
The marker should stay outside the list item's content, to its left. Instead it moved on
top of the content.
An outside marker is pulled out of the line by a negative inline-start margin, which
updateInlineMargins() wrote with the logical setter. That resolves start against the
marker's own direction, so a right-to-left marker got the negative margin on its right
edge. Both readers ask the other way around, BoxGeometryUpdater against the parent's
writing mode and RenderBlock::marginStartForChild against the containing block's, so
they found nothing on the left and the marker stayed on the content.
Write the physical edges of the list item's inline axis instead: left and right in a
horizontal writing mode, top and bottom in a vertical one, which is the axis those readers
take them from. That is what css-lists-3 asks for as well: with marker-side: match-self,
its initial value, the marker box is positioned using the directionality of the ::marker's
originating element rather than the marker's own.
WebKit-Bug: https://bugs.webkit.org/show_bug.cgi?id=321399
WebKit-Canonical-Link: https://commits.webkit.org/318888@main
wpt-pr-bot
approved these changes
Oct 25, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the WebKit project.
annevk
enabled auto-merge (rebase)
October 25, 2026 08:55
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebKit export from bug: [list-marker] direction on ::marker moves the marker box to the wrong side of the list item
[list-marker] direction on ::marker moves the marker box to the wrong side of the list item <style> ::marker { direction: rtl } </style> <ol><li>text The marker should stay outside the list item's content, to its left. Instead it moved on top of the content. An outside marker is pulled out of the line by a negative inline-start margin, which updateInlineMargins() wrote with the logical setter. That resolves start against the marker's own direction, so a right-to-left marker got the negative margin on its right edge. Both readers ask the other way around, BoxGeometryUpdater against the parent's writing mode and RenderBlock::marginStartForChild against the containing block's, so they found nothing on the left and the marker stayed on the content. Write the physical edges of the list item's inline axis instead: left and right in a horizontal writing mode, top and bottom in a vertical one, which is the axis those readers take them from. That is what css-lists-3 asks for as well: with marker-side: match-self, its initial value, the marker box is positioned using the directionality of the ::marker's originating element rather than the marker's own. WebKit-Bug: https://bugs.webkit.org/show_bug.cgi?id=321399 WebKit-Canonical-Link: https://commits.webkit.org/318888@main