Repository navigation
Conversation
A legend that reaches past its fieldset's border edge is carried as an intrinsic border, which RenderBlock::borderBefore adds to the fieldset's border. The border box height the fieldset ends up with is measured with that border in it, so RenderBox::contentBoxHeight has nothing left and clamps at zero. updateLayoutBoxDimensions builds the geometry for a box on a line from both of those: the content box height from the renderer, and the border from adjustBorderForTableAndFieldset, which adds the intrinsic border again. The margin box the line gets is then max(0, H - BP) + BP, which is BP rather than H whenever the legend overhangs, so the fieldset takes the overhang twice and its container grows by it. The overhang belongs to the fieldset's own content: the lines inside it start below the legend. It says nothing about the box a line holds, whose inner layout the render tree does. So take it where the fieldset is the formatting context root and nowhere else, which leaves logicalBorder about a table's collapsed borders. The content box size comes from what is left of the border box, since the renderer's own answer is measured against a border that has the overhang in it. Only the fieldset's own block axis grew, which is the container's inline axis when the two writing modes differ in orientation. WebKit-Bug: https://bugs.webkit.org/show_bug.cgi?id=321504 WebKit-Canonical-Link: https://commits.webkit.org/319033@main
wpt-pr-bot
approved these changes
Oct 25, 2026
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the WebKit project.
annevk
enabled auto-merge (rebase)
October 25, 2026 08:55
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebKit export from bug: [block-in-inline] A fieldset on a line takes its legend's overhang twice