Repository navigation
Conversation
…ough computed style are being serialized incorrectly Removes incorrect zoom unscaling of px values in computed value calc() expressions that was left over from build time zoom. Now that no zoom unscaling is needed, the Style::ComputedStyle passed during conversion from Style::UnevaluatedCalculation to CSS::UnevalutatedCalc can be removed. Also simplified toCSS conversion for numeric types a bit by using unresolvedValue() for all numeric types instead of specializing for Length<>. WebKit-Bug: https://bugs.webkit.org/show_bug.cgi?id=321939 WebKit-Canonical-Link: https://commits.webkit.org/319320@main
wpt-pr-bot
approved these changes
Oct 25, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the WebKit project.
annevk
enabled auto-merge (rebase)
October 25, 2026 08:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebKit export from bug: [EvaluationTimeZoom] px values in calc() expressions that survive through computed style are being serialized incorrectly