-
-
Notifications
You must be signed in to change notification settings - Fork 198
feat(theme)!: use named export instead of default export, for circular imports #1873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aquamarine-blini-95325f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
275b4e6 to
7b42345
Compare
import Theme from 'rspress/theme', circular dependencies
import Theme from 'rspress/theme', circular dependenciesb11f016 to
8eb5325
Compare
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 tasks
1bff745 to
1b7142f
Compare
Timeless0911
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Summary
web-infra-dev/rsbuild#2862
@themeis for customizing the theme, but it causes circular dependencies which breaks the ssg renderinglogic/index.tsandcomponents/index.tsTHIS IS A BREAKING CHANGE
if you want to customize HomeLayout, please use below:
before
after
Related Issue
Pages render error: ReferenceError: Cannot access 'src_rslib_entry ' before initializationChecklist