Optimize string concatenation in hot paths #12058
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identified and fixed inefficient string concatenation patterns causing unnecessary allocations in frequently-executed code paths.
Changes
compile_boolean_matcher.rs: Pre-allocate string capacity and usepush_str()instead of+=operator when building single-character regex patternsdependencies_block.rs: Replacefoldwith+=with idiomaticmap().collect::<String>()pattern for dependency ID generationeval/mod.rs: Replace manual loop with iterator-based collection for template string evaluationExample
Before:
After:
Additional Observations
Minor optimization opportunities remain but are out of scope for this focused change:
.chars().count() == 1could use early terminationHashMap/HashSetinstances lack capacity hintsOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.