Skip to content

Conversation

@deer-wmde
Copy link
Contributor

@deer-wmde deer-wmde commented Jun 27, 2025

https://phabricator.wikimedia.org/T397905

  • this adds new Classes:
    • ComplaintRecord
      • persists incoming form data, before trying to send mails
    • ComplaintController
      • handles new form route /complaint/sendMessage
    • ComplaintNotification
      • Internal mail template
    • ComplaintNotificationExternal
      • External mail template (user confirmation)

what I need help with:

the test case testRecordOnMailFail can successfully test if the input gets persisted even if we can't send the mails, but as this triggers an Exception it pollutes the test suite output

@deer-wmde deer-wmde marked this pull request as ready for review July 18, 2025 12:07
Copy link
Contributor

@rosalieper rosalieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per the figma, the max here is 1000

@rosalieper rosalieper merged commit 6fb4de9 into main Jul 25, 2025
5 checks passed
@rosalieper rosalieper deleted the de/dsa-form branch July 25, 2025 13:02
deer-wmde added a commit that referenced this pull request Dec 15, 2025
* add config vars for sending complaint mails

* add ComplaintNotification

* clearer naming

* add ComplaintController

* add route

* add ExternalComplaintNotification

* templating

* switch order of notifications

* add WIP tests

* restrict email validation to rfc filter

* fix email validation rule condition

* add multi mail address test case

* refactored class naming

* WIP persist notifications in database

* add ComplaintRecord class

* extend test cases

* adjust field names to UI code

* fix testRecordOnMailFail status code assert

* adjust parameter names in test case

* reduce size limit of text fields to 1000

* fix field names in test

* remove form contents from externail mail notification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants