Add metrics: monthly casual users and active users #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrow
reviewed
May 22, 2025
| 'quarterly_actions', | ||
| 'number_of_triples', | ||
| 'monthly_casual_users', | ||
| 'monthly_active_users', |
Contributor
There was a problem hiding this comment.
This also needs to be added to the metricNames list or the comparison for seeing if we need to add new a new record won't work
Contributor
|
Mostly looks fine to me; as I mentioned yesterday let's get together and have another stab at adding some tests for this stuff because right now we don't which is a little unpleasant and makes touching these areas slower (we always need to manually test them. |
Contributor
|
I added the metric names in the static array, added bits to the migration code and tested the query on staging; If you don't see anything else I think this is ready for staging @tarrow |
Contributor
|
@rosalieper and I looked at this together and I stick the approve on it (even though the last changes were from me but we reviewd it) |
deer-wmde
approved these changes
May 27, 2025
deer-wmde
approved these changes
May 27, 2025
deer-wmde
added a commit
that referenced
this pull request
Dec 15, 2025
* add DB migration * Add metrics monthly casual users and active users * add new metrics to WikiDailyMetrics::$metricNames as well * fix migration reversal code * update changelog --------- Co-authored-by: dena <dena@wikimedia.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.