chore: streamline k8s job TTLs (#1008)

deer-wmde · deer-wmde · commit 911f2d0419e3 · 2025-12-15T18:41:49.000+01:00
Jobs with 0 TTL are harder to inspect as the job is destroyed after finishing.

This patch sets a standard length of TTL for k8s jobs or adds a comment to explain why a longer TTL can't be used.

Bug: T411792
diff --git a/app/Jobs/ProcessMediaWikiJobsJob.php b/app/Jobs/ProcessMediaWikiJobsJob.php
@@ -74,6 +74,7 @@ public function handle(Client $kubernetesClient, MediaWikiHostResolver $resolver
                 ],
             ],
             'spec' => [
+                // This is set to immediately expire since the name of the job is used as the lock to prevent creating duplicates of this Kubernetes Job for any given Wiki.
                 'ttlSecondsAfterFinished' => 0,
                 'template' => [
                     'metadata' => [
diff --git a/app/Jobs/SpawnQueryserviceUpdaterJob.php b/app/Jobs/SpawnQueryserviceUpdaterJob.php
@@ -67,7 +67,7 @@ public function handle(Client $kubernetesClient): void {
                 ],
             ],
             'spec' => [
-                'ttlSecondsAfterFinished' => 14 * 24 * 60 * 60, // 2 weeks
+                'ttlSecondsAfterFinished' => 24 * 60 * 60 * 7, // 1 week
                 'template' => [
                     'metadata' => [
                         'name' => 'run-qs-updater',
diff --git a/app/Jobs/WikiEntityImportJob.php b/app/Jobs/WikiEntityImportJob.php
@@ -153,7 +153,7 @@ private function constructSpec(): array {
                 ],
             ],
             'spec' => [
-                'ttlSecondsAfterFinished' => 0,
+                'ttlSecondsAfterFinished' => 24 * 60 * 60 * 7, // 1 week
                 'backoffLimit' => 0,
                 'template' => [
                     'metadata' => [
